[PATCH v2 03/16] arm: rockchip: add RK3576-specific syscon ids

Jonas Karlman jonas at kwiboo.se
Tue Apr 15 00:44:49 CEST 2025


Hi Heiko,

On 2025-04-14 22:00, Heiko Stuebner wrote:
> From: Detlev Casanova <detlev.casanova at collabora.com>
> 
> The rk3576 defines some more different syscons, namely the IOC-syscon
> holding io-controller registers and sdgmac holding settings for the
> gmac controller.
> 
> Signed-off-by: Detlev Casanova <detlev.casanova at collabora.com>
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
> ---
>  arch/arm/include/asm/arch-rockchip/clock.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-rockchip/clock.h b/arch/arm/include/asm/arch-rockchip/clock.h
> index a9921fbb6e4..533f8bd89eb 100644
> --- a/arch/arm/include/asm/arch-rockchip/clock.h
> +++ b/arch/arm/include/asm/arch-rockchip/clock.h
> @@ -39,6 +39,8 @@ enum {
>  	ROCKCHIP_SYSCON_PIPE_PHY2_GRF,
>  	ROCKCHIP_SYSCON_VOP_GRF,
>  	ROCKCHIP_SYSCON_VO_GRF,
> +	ROCKCHIP_SYSCON_IOC,
> +	ROCKCHIP_SYSCON_SDGMAC,

These are not really needed, the gmac and pinctrl drivers get these
syscon/regmap using the phandle from rockchip,grf/php-grf props.

I also have a very slow going work-in-progress series that eventually
hopefully will drop most if not all of these syscon ids, see [1].

So please drop this patch.

[1] https://source.denx.de/u-boot/contributors/kwiboo/u-boot/-/commits/optimize

Regards,
Jonas

>  };
>  
>  /* Standard Rockchip clock numbers */



More information about the U-Boot mailing list