[PATCH v2 05/16] pinctrl: rockchip: support rk3576 pinctrl

[Jonas Karlman]

Hi Heiko,

On 2025-04-14 22:01, Heiko Stuebner wrote:
> From: Steven Liu <steven.liu at rock-chips.com>
> 
> Add support for the rk3576 variant of pinctrl.
> 
> Signed-off-by: Steven Liu <steven.liu at rock-chips.com>
> [adapted to mainline u-boot]
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> ---
>  drivers/pinctrl/rockchip/Makefile           |   1 +
>  drivers/pinctrl/rockchip/pinctrl-rk3576.c   | 279 ++++++++++++++++++++
>  drivers/pinctrl/rockchip/pinctrl-rockchip.h |   3 +
>  3 files changed, 283 insertions(+)
>  create mode 100644 drivers/pinctrl/rockchip/pinctrl-rk3576.c
> 
> diff --git a/drivers/pinctrl/rockchip/Makefile b/drivers/pinctrl/rockchip/Makefile
> index df6c97d6234..e17415e1ca6 100644
> --- a/drivers/pinctrl/rockchip/Makefile
> +++ b/drivers/pinctrl/rockchip/Makefile
> @@ -16,6 +16,7 @@ obj-$(CONFIG_ROCKCHIP_RK3368) += pinctrl-rk3368.o
>  obj-$(CONFIG_ROCKCHIP_RK3399) += pinctrl-rk3399.o
>  obj-$(CONFIG_ROCKCHIP_RK3528) += pinctrl-rk3528.o
>  obj-$(CONFIG_ROCKCHIP_RK3568) += pinctrl-rk3568.o
> +obj-$(CONFIG_ROCKCHIP_RK3576) += pinctrl-rk3576.o
>  obj-$(CONFIG_ROCKCHIP_RK3588) += pinctrl-rk3588.o
>  obj-$(CONFIG_ROCKCHIP_RV1108) += pinctrl-rv1108.o
>  obj-$(CONFIG_ROCKCHIP_RV1126) += pinctrl-rv1126.o
> diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3576.c b/drivers/pinctrl/rockchip/pinctrl-rk3576.c
> new file mode 100644
> index 00000000000..589a9b8491c
> --- /dev/null
> +++ b/drivers/pinctrl/rockchip/pinctrl-rk3576.c

[snip]

> +static const struct rockchip_pin_ctrl rk3576_pin_ctrl = {
> +	.pin_banks		= rk3576_pin_banks,
> +	.nr_banks		= ARRAY_SIZE(rk3576_pin_banks),
> +	.nr_pins		= 160,

This property is removed in Quentin Schulz "pinctrl: rockchip: fix
editing const struct + constify rockchip_pin_ctrl" series [1].

Suggest you drop this property to ease merging of both these series.

With that fixes this is:

Reviewed-by: Jonas Karlman <jonas at kwiboo.se>

[1] https://patchwork.ozlabs.org/cover/2040824/

Regards,
Jonas

> +	.grf_mux_offset		= 0x0,
> +	.set_mux		= rk3576_set_mux,
> +	.set_pull		= rk3576_set_pull,
> +	.set_drive		= rk3576_set_drive,
> +	.set_schmitt		= rk3576_set_schmitt,
> +};

[snip]