[PATCH] stm32mp: Add nvram driver

[Patrick DELAUNAY]

Hi,

On 4/11/25 18:03, Patrice Chotard wrote:
> From: Simeon Marijon <simeon.marijon at foss.st.com>
>
> TAMP backup registers will be exposed as nvmem cells.
>
> Each registers ([0..127] for STM32MP2, [0..31] for STM32MP1) could be
> exposed as nvmem cells under the nvram node in device tree
>
> Signed-off-by: Simeon Marijon <simeon.marijon at foss.st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard at foss.st.com>
> ---
>
>   arch/arm/mach-stm32mp/Kconfig  |   9 +
>   arch/arm/mach-stm32mp/Makefile |   2 +
>   arch/arm/mach-stm32mp/nvram.c  | 664 +++++++++++++++++++++++++++++++++
>   3 files changed, 675 insertions(+)
>   create mode 100644 arch/arm/mach-stm32mp/nvram.c
>
> diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig
> index 002da2e3d3b..d7323659811 100644
> --- a/arch/arm/mach-stm32mp/Kconfig
> +++ b/arch/arm/mach-stm32mp/Kconfig
> @@ -144,6 +144,15 @@ config STM32_ECDSA_VERIFY
>   	  ROM API provided on STM32MP.
>   	  The ROM API is only available during SPL for now.
>   
> +config STM32MP_TAMP_NVMEM
> +	bool "STM32 TAMP backup registers via NVMEM API"
> +	select NVMEM
> +	default y
> +	help
> +	  Say y to enable the uclass driver for TAMP Backup registers using the
> +	  NVMEM API. It allows to access to boot mode or others shared information
> +	  between software components/execution levels.
> +
>   config CMD_STM32KEY
>   	bool "command stm32key to fuse public key hash"
>   	depends on CMDLINE
> diff --git a/arch/arm/mach-stm32mp/Makefile b/arch/arm/mach-stm32mp/Makefile
> index 103e3410ad9..bc0fe9e2225 100644
> --- a/arch/arm/mach-stm32mp/Makefile
> +++ b/arch/arm/mach-stm32mp/Makefile
> @@ -13,6 +13,8 @@ obj-$(CONFIG_STM32MP13X) += stm32mp1/
>   obj-$(CONFIG_STM32MP25X) += stm32mp2/
>   
>   obj-$(CONFIG_MFD_STM32_TIMERS) += timers.o
> +obj-$(CONFIG_STM32MP_TAMP_NVMEM) += nvram.o


I don't see  reason to have reduce file name her ?

filename indicate only the type nvram for nvmem used for TAMP backup 
register.


I prefer fine name with indication of the device used, here TAMP ,

and aligned with driver name "stm32_tamp_nvram"

so rename nvram.c => tamp_nvram.c

and

+obj-$(CONFIG_STM32MP_TAMP_NVMEM) += tamp_nvram.o


thanks


With this minor remark


Reviewed-by: Patrick Delaunay <patrick.delaunay at foss.st.com>

Thanks
Patrick