[PATCH v2 3/3] Image size checks: Simplify help text

[Heinrich Schuchardt]

Philip Oberfichtner <pro at denx.de> schrieb am Mo., 11. Aug. 2025, 10:57:

> On Thu, Aug 07, 2025 at 03:41:57PM +0200, Marek Vasut wrote:
> > On 8/7/25 12:24 PM, Philip Oberfichtner wrote:
> > > For coherency, use the same help text for all related size checks
> > > options. Furthermore, simplify the depends-on logic.
>

If you want to make two unrelated changes, please, create two separate
patches.

Best regards

Heinrich


> >
> > > Signed-off-by: Philip Oberfichtner <pro at denx.de>
> > > ---
> > >
> > > Notes:
> > >      Changes in v2: new
> > >
> > >   Kconfig | 8 +++-----
> > >   1 file changed, 3 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Kconfig b/Kconfig
> > > index ec20603883b..490a706101a 100644
> > > --- a/Kconfig
> > > +++ b/Kconfig
> > > @@ -543,10 +543,8 @@ config BOARD_SIZE_LIMIT
> > >     default 1048576 if RCAR_64
> > >     default 0
> > >     help
> > > -     Maximum size of the U-Boot image. When defined, the build system
> > > -     checks that the actual size does not exceed it.  This does not
> > > -     include SPL nor TPL, on platforms that use that functionality,
> they
> > > -     have separate options to restrict size.
> > > +     Specifies the maximum length of the U-Boot image.
> > > +     If this value is zero, it is ignored.
> >
> > This makes the description less accurate, sorry, NAK.
>
> What about using just the first half:
>
>         Maximum size of the U-Boot image. When defined, the build system
>         checks that the actual size does not exceed it.
>         [plus/minus treatment of the value zero]
>
> And dropping the remainder "This does not include ..."?
>
> I think the hint on the separate options would be unnecessary, if they
> are placed placed just below.
>
> Best regards,
> Philip
>
>
>
>
> --
> =====================================================================
> DENX Software Engineering GmbH,
> Managing Director: Johanna Denk, Tabea Lutz
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> =====================================================================
>