[PATCH v1 1/2] imx8ulp_evk: Move environment variables to .env file
Tom Rini
trini at konsulko.com
Tue Dec 2 03:16:53 CET 2025
On Tue, Dec 02, 2025 at 01:49:24AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH v1 1/2] imx8ulp_evk: Move environment variables
> > to .env file
> >
> > On Mon, Dec 01, 2025 at 06:56:56PM +0800, alice.guo at oss.nxp.com
> > wrote:
> >
> > > From: Alice Guo <alice.guo at nxp.com>
> > >
> > > Add board-specific environment variables to imx8ulp_evk.env for
> > better
> > > maintainability.
> > >
> > > Signed-off-by: Alice Guo <alice.guo at nxp.com>
> > [snip]
> > > +fdt_high=0xffffffffffffffff
> >
> > NAK. I just the other week sent out 40+ patches removing that setting
> > from other platforms and you weren't even setting it before.
>
> How about add a check in checkpatch.pl to give a warning on this?
There's already one which this triggered and is an ERROR level as well.
It also tells you not to disable initrd relocation, which is just a bad
idea in many cases, rather than often fatal to the OS like fdt_high is.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251201/418186e1/attachment.sig>
More information about the U-Boot
mailing list