[PATCH 01/23] board: st: Drop old LED code from stm32f429-disco

Quentin Schulz quentin.schulz at cherry.de
Thu Dec 4 14:12:47 CET 2025


Hi Patrice,

On 11/14/25 5:23 PM, Patrice Chotard wrote:
> From: Simon Glass <sjg at chromium.org>
> 
> This predates the LED framework, so drop it.
> 

Well, we could still use it with the legacy LED API if we enable it, but 
stm32f429-discovery_defconfig doesn't, so I guess it's fine?

Since it was disabled, I assume we don't need/want to migrate it to the 
new LED framework using DT?

Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

Thanks!
Quentin

> Signed-off-by: Simon Glass <sjg at chromium.org>
> Signed-off-by: Patrice Chotard <patrice.chotard at foss.st.com>
> ---
> 
>   board/st/stm32f429-discovery/Makefile |  1 -
>   board/st/stm32f429-discovery/led.c    | 39 ---------------------------
>   2 files changed, 40 deletions(-)
>   delete mode 100644 board/st/stm32f429-discovery/led.c
> 
> diff --git a/board/st/stm32f429-discovery/Makefile b/board/st/stm32f429-discovery/Makefile
> index 6b02c0fddec..233eafdad3d 100644
> --- a/board/st/stm32f429-discovery/Makefile
> +++ b/board/st/stm32f429-discovery/Makefile
> @@ -7,4 +7,3 @@
>   # Kamil Lulko, <kamil.lulko at gmail.com>
>   
>   obj-y	:= stm32f429-discovery.o
> -obj-y	+= led.o
> diff --git a/board/st/stm32f429-discovery/led.c b/board/st/stm32f429-discovery/led.c
> deleted file mode 100644
> index 4b8038341b9..00000000000
> --- a/board/st/stm32f429-discovery/led.c
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+
> -/*
> - * (C) Copyright 2015
> - * Kamil Lulko, <kamil.lulko at gmail.com>
> - */
> -
> -#include <status_led.h>
> -#include <asm-generic/gpio.h>
> -
> -#define RED_LED			110
> -#define GREEN_LED		109
> -
> -void coloured_LED_init(void)
> -{
> -	gpio_request(RED_LED, "red led");
> -	gpio_direction_output(RED_LED, 0);
> -	gpio_request(GREEN_LED, "green led");
> -	gpio_direction_output(GREEN_LED, 0);
> -}
> -
> -void red_led_off(void)
> -{
> -	gpio_set_value(RED_LED, 0);
> -}
> -
> -void green_led_off(void)
> -{
> -	gpio_set_value(GREEN_LED, 0);
> -}
> -
> -void red_led_on(void)
> -{
> -	gpio_set_value(RED_LED, 1);
> -}
> -
> -void green_led_on(void)
> -{
> -	gpio_set_value(GREEN_LED, 1);
> -}



More information about the U-Boot mailing list