[PATCH 02/23] board: st: Update LED management for stm32mp1

Quentin Schulz quentin.schulz at cherry.de
Thu Dec 4 16:38:04 CET 2025


Hi Patrice,

On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Remove get_led() and setup_led() which became obsolete since
> led_boot_on() introduction. led_boot_on() is automatically called
> from board_r.c
> 

Yes, but called later than board_init(). If this compromise is fine then 
it's ok.

> Regarding "u-boot,error-led" property can't be used anymore since commit
> Since commit 516a13e8db32 ("led: update LED boot/activity to new property implementation")
> 
> Instead get the LED labeled "red:status".

Would this work with stm32mp157a-dhcor-avenger96 (led4), 
stm32mp157c-odyssey (red but not "status" as function?) and 
stm32mp15xx-dhcom (error but possibly broken since commit 
332facce6f5669fc1bb8d150c08cee2ebdae6d2b which removed the led with that 
label)? Seems like Odissey has LED=y and LED_GPIO=y so it probably 
worked before this patch? The other two, their defconfigs don't seem to 
enable LED support (new or legacy) so I guess it never was used anyway?

I'm also wondering how you get this string... I don't see any label or 
LED_FUNCTION_STATUS function for the LED devices on ST boards. I'm 
probably missing on something?

Cheers,
Quentin


More information about the U-Boot mailing list