[PATCH] arm: dts: mediatek: switch mt8365 to OF_UPSTREAM
Macpaul Lin (林智斌)
Macpaul.Lin at mediatek.com
Fri Dec 5 04:16:59 CET 2025
On Tue, 2025-11-25 at 11:35 -0600, David Lechner wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> Change mt8365_evk_defconfig to use CONFIG_OF_UPSTREAM=y and delete
> the
> U-Boot copy of the devicetree source files for mt8365.
>
> The upstream devicetree is identical to the U-Boot one being removed
> (other than having more nodes for devices not used by U-Boot and
> upstream fixed a compatible string in &scpsys, also not affecting
> U-Boot).
>
> There was one minor glitch with upstream missing a few topckgen macro
> definitions, so those are added to the clock driver directly as a
> workaround.
>
> Signed-off-by: David Lechner <dlechner at baylibre.com>
> ---
> arch/arm/dts/mt8365-evk.dts | 418 ------------
> arch/arm/dts/mt8365.dtsi | 840 --------------
> ----------
> board/mediatek/mt8365_evk/MAINTAINERS | 1 -
> configs/mt8365_evk_defconfig | 3 +-
> drivers/clk/mediatek/clk-mt8365.c | 4 +
> include/dt-bindings/clock/mediatek,mt8365-clk.h | 375 -----------
> 6 files changed, 6 insertions(+), 1635 deletions(-)
>
Thanks for your observation!
However, there are some basic checks should be ran and
please keep in mind before you send the patch.
1. Please always put the Maintainers and Reviewers (run
./script/get_maintainer.pl) in "To:" when you
send the patch.
Otherwise reviewers might simply filter mail to the other folders
in mail client and skip it.
2. Please always run ./script/checkpatch.pl and check errors
before send out the patch.
I've download this patch (.mbox) from evolution and found
the following errors must be fixed.
ERROR: DOS line endings
#1809: FILE: configs/mt8365_evk_defconfig:8:
+CONFIG_DEFAULT_DEVICE_TREE=3D"mediatek/mt8365-evk"^M$
ERROR: DOS line endings
#1815: FILE: configs/mt8365_evk_defconfig:14:
+CONFIG_OF_UPSTREAM=3Dy^M$
ERROR: patch seems to be corrupt (line wrapped?)
#1828: FILE: drivers/clk/mediatek/clk-mt8365.c:14:
ERROR: DOS line endings
#1829: FILE: drivers/clk/mediatek/clk-mt8365.c:15:
+/* Missing topckgen clocks definition in dt-bindings */^M$
ERROR: DOS line endings
#1830: FILE: drivers/clk/mediatek/clk-mt8365.c:16:
+#define CLK_TOP_CLK26M 141^M$
ERROR: DOS line endings
#1831: FILE: drivers/clk/mediatek/clk-mt8365.c:17:
+#define CLK_TOP_CLK32K 142^M$
ERROR: DOS line endings
#1832: FILE: drivers/clk/mediatek/clk-mt8365.c:18:
+^M$
total: 7 errors, 2 warnings, 0 checks, 36 lines checked
Best regards,
Macpaul Lin
More information about the U-Boot
mailing list