[PATCH 2/2] clk: mediatek: add MT8188 clock driver

[Macpaul Lin (林智斌)]

On Wed, 2025-12-03 at 10:31 +0100, Julien Stephan wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> From: Julien Masson <jmasson at baylibre.com>
> 
> The following clocks have been added for MT8188 SoC:
> apmixedsys, topckgen, infracfg, pericfg and imp_iic_wrap
> 
> These clocks driver are based on the ones present in the kernel:
> drivers/clk/mediatek/clk-mt8188-*
> 
> Signed-off-by: Julien Masson <jmasson at baylibre.com>
> Signed-off-by: Julien Stephan <jstephan at baylibre.com>
> ---
>  drivers/clk/mediatek/Makefile     |    1 +
>  drivers/clk/mediatek/clk-mt8188.c | 1840
> +++++++++++++++++++++++++++++++++++++
>  2 files changed, 1841 insertions(+)
> 
> 
Thanks for helping upstream these SOC to u-boot upstream.
However, I've also found it seems lots of formatting issues (errors
and warnings) in coding style when I ran checkpatch through
these patches.

Please help to fix them as could as possible.

[snip]


> diff --git a/drivers/clk/mediatek/Makefile
> b/drivers/clk/mediatek/Makefile
> index
> 12893687b68fc6c136a06e19305b1dd0c8a8101a..68b3d6e9610d8e7f4c4c625f52e
> 525174e92787a 100644
> --- a/drivers/clk/mediatek/Makefile
> +++ b/drivers/clk/mediatek/Makefile
> @@ -11,6 +11,7 @@ obj-$(CONFIG_TARGET_MT7981) += clk-mt7981.o
>  obj-$(CONFIG_TARGET_MT7988) += clk-mt7988.o
>  obj-$(CONFIG_TARGET_MT7987) += clk-mt7987.o
>  obj-$(CONFIG_TARGET_MT8183) += clk-mt8183.o
> +obj-$(CONFIG_TARGET_MT8188) += clk-mt8188.o
>  obj-$(CONFIG_TARGET_MT8365) += clk-mt8365.o
>  obj-$(CONFIG_TARGET_MT8512) += clk-mt8512.o
>  obj-$(CONFIG_TARGET_MT8516) += clk-mt8516.o
> diff --git a/drivers/clk/mediatek/clk-mt8188.c
> b/drivers/clk/mediatek/clk-mt8188.c
> new file mode 100644
> index
> 0000000000000000000000000000000000000000..e47dc3e628055910300f97ff9c3
> 9fed10d56d7fe
> --- /dev/null
> +++ b/drivers/clk/mediatek/clk-mt8188.c
> @@ -0,0 +1,1840 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * MediaTek clock driver for MT8188 SoC
> + *
> + * Copyright (C) 2024 BayLibre, SAS

Shouldn't this Copyright be changed to 2025 for a new file be
added into upstream code base?

> + * Copyright (c) 2024 MediaTek Inc.
> + * Authors: Julien Masson <jmasson at baylibre.com>
> + *         Garmin Chang <garmin.chang at mediatek.com>
> + */
> +

[snip]

Best regards,
Macpaul Lin