[PATCH v2 0/3] clk: Return value calculated by ERR_PTR

[Tom Rini]

On Thu, Dec 11, 2025 at 07:51:09AM -0600, Nishanth Menon wrote:
> On 07:47-20251211, Tom Rini wrote:
> > On Thu, Dec 11, 2025 at 05:42:26AM -0600, Nishanth Menon wrote:
> > > On 10:35-20251208, Nishanth Menon wrote:
> > > > On 15:52-20251208, Andrew Goodbody wrote:
> > > 
> > > [..]
> > > > > > > Confirmed by reverting the commit. Looks like
> > > > > > > 9ed8fafbcde3425d8817ec5953edd428c7508153 revert is needed again?
> > > > > > 
> > > > > > Interesting, OK. What Andrew did in commit
> > > > > > fe780310cfa8bf5a093894b5cd7fe85c6b02fd91 is more complex than before and
> > > > > > there's two stanzas there. Our lab is current being re-worked again
> > > > > > right now so I can't test on the K3 platforms I have, but can you please
> > > > > > see which of the two changes in clk-uclass.c is the one that breaks
> > > > > > these platforms? Thanks!
> > > > > What is the breakage please? I did put this series through CI and the only
> > > > > issues were due to lack of disk space, so not related to the patches.
> > > > > 
> > > > > Andrew
> > > > > 
> > > > Looks like A72 would'nt get started.. adding a bit of print to get an
> > > > idea:
> > > > 
> > > > https://gist.github.com/nmenon/c0487b99cbd2308ccd11ffe510a780bb
> > > > 
> > > 
> > > 
> > > Any suggestions to proceed?
> > 
> > Can you please see which of the two changes to clk-uclass.c is the one
> > at fault, or if it's both? Thanks!
> 
> 
> The logs show the details
> https://gist.github.com/nmenon/c0487b99cbd2308ccd11ffe510a780bb#file-log-patch-L12
> (return ERR_PTR) triggers the flow in https://gist.github.com/nmenon/c0487b99cbd2308ccd11ffe510a780bb#file-log-patch-L19
> and fails
> 
> This looks like the clock for A72 that needs to be set from R5 SPL to
> start up A72 - with the fail, A72 does'nt start up.

Thanks. Andrew, I think instead of return ERR_PTR(ret) we should just
drop the line there and keep just a debug print. Which also means that a
bunch of this code seems to be written oddly, given the required
behavior.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251211/dc319709/attachment.sig>