[PATCH v2 2/6] net: Move some variables to net-common files

[Jerome Forissier]

On 12/12/25 12:32, Andrew Goodbody wrote:
> Make some variables available to be used by either the legacy network
> code or lwIP by moving them into the net-common files. This also allowed
> removing a small number of duplicated variables from the lwIP code.
> 
> Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
> ---
>  include/net-common.h | 12 ++++++++++--
>  include/net-legacy.h |  5 -----
>  net/lwip/net-lwip.c  |  5 -----
>  net/net-common.c     |  9 +++++++++
>  net/net.c            | 10 ----------
>  5 files changed, 19 insertions(+), 22 deletions(-)
> 
> diff --git a/include/net-common.h b/include/net-common.h
> index d7a0f7dff7e50527e77419ead9a9ff30deeea545..f293b21bc0bb3c8e1a04ffd8f5188e5ce67d1d12 100644
> --- a/include/net-common.h
> +++ b/include/net-common.h
> @@ -132,13 +132,21 @@ static inline void net_set_state(enum net_loop_state state)
>  }
>  
>  extern int		net_restart_wrap;	/* Tried all network devices */
> -extern uchar               *net_rx_packets[PKTBUFSRX]; /* Receive packets */
> +extern uchar		*net_rx_packets[PKTBUFSRX]; /* Receive packets */
>  extern const u8		net_bcast_ethaddr[ARP_HLEN];	/* Ethernet broadcast address */
> -extern char	net_boot_file_name[1024];/* Boot File name */
>  extern struct in_addr	net_ip;		/* Our    IP addr (0 = unknown) */
>  /* Indicates whether the pxe path prefix / config file was specified in dhcp option */
>  extern char *pxelinux_configfile;
>  
> +/* Our IP addr (0 = unknown) */
> +extern struct in_addr	net_ip;

That one is already mentioned above. Please remove.
The rest of the patch looks fine, so with this fixed:

Reviewed-by: Jerome Forissier <jerome.forissier at linaro.org>

Thanks,
-- 
Jerome