[PATCH] firmware: scmi: sandbox: Use scmi_clk_state_in_v2

[Marek Vasut]

On 12/10/25 6:09 PM, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan at nxp.com>
> 
> The sandbox scmi clock protocol use version 3.0, so need to use
> scmi_clk_state_in_v2.
> 
> Fixes: 0619cb32030b ("firmware: scmi: Add clock v3.2 CONFIG_SET support")
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> ---
>   drivers/firmware/scmi/sandbox-scmi_agent.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/scmi/sandbox-scmi_agent.c b/drivers/firmware/scmi/sandbox-scmi_agent.c
> index 5b242a039c2..010bf99fbc6 100644
> --- a/drivers/firmware/scmi/sandbox-scmi_agent.c
> +++ b/drivers/firmware/scmi/sandbox-scmi_agent.c
> @@ -828,7 +828,7 @@ static int sandbox_scmi_clock_rate_get(struct udevice *dev,
>   
>   static int sandbox_scmi_clock_gate(struct udevice *dev, struct scmi_msg *msg)
>   {
> -	struct scmi_clk_state_in_v1 *in = NULL;
> +	struct scmi_clk_state_in_v2 *in = NULL;
>   	struct scmi_clk_state_out *out = NULL;
>   	struct sandbox_scmi_clk *clk_state = NULL;
>   
> @@ -836,7 +836,7 @@ static int sandbox_scmi_clock_gate(struct udevice *dev, struct scmi_msg *msg)
>   	    !msg->out_msg || msg->out_msg_sz < sizeof(*out))
>   		return -EINVAL;
>   
> -	in = (struct scmi_clk_state_in_v1 *)msg->in_msg;
> +	in = (struct scmi_clk_state_in_v2 *)msg->in_msg;
How did this ever work before "0619cb32030b ("firmware: scmi: Add clock 
v3.2 CONFIG_SET support")" ? The "0619cb32030b ("firmware: scmi: Add 
clock v3.2 CONFIG_SET support")" did not change the behavior, so I think 
this is not a fix.