[PATCH v1 5/7] usb: Kconfig: imply DM_USB_GADGET

[Quentin Schulz]

Hi Alice,

On 12/16/25 7:38 AM, alice.guo at oss.nxp.com wrote:
> From: Sherry Sun <sherry.sun at nxp.com>
> 
> Since the ci_udc driver has been converted to DM driver, the
> CONFIG_DM_USB_GADGET should also be selected when CONFIG_CI_UDC
> is enabled, then we can use DM ci_udc driver.
> 

Is DM_USB_GADGET *required* for CI_UDC to work? "imply" allows to have 
DM_USB_GADGET=y AND CI_UDC=n, which is probably not what you want. You 
probably simply want "depends on DM_USB_GADGET"

> Signed-off-by: Sherry Sun <sherry.sun at nxp.com>
> Signed-off-by: Alice Guo <alice.guo at nxp.com>
> Reviewed-by: Ye Li <ye.li at nxp.com>

Please do not provide Reviewed-by on the first version of a patch, 
Reviewed-by, Acked-by, Tested-by, etc.... should be given publicly on 
the mailing list. We don't know if Ye Li actually reviewed it or if you 
unilaterally decided they reviewed it. We don't know if we can trust 
it... which we shouldn't have to figure out.

Cheers,
Quentin