[PATCH v4 2/3] clk: scmi: Fix priv initialization in scmi_clk_gate()

Marek Vasut marek.vasut at mailbox.org
Thu Dec 18 11:04:01 CET 2025


On 12/18/25 10:58 AM, Patrice CHOTARD wrote:

Hello Patrice,

>>> @@ -156,6 +156,16 @@ static int scmi_clk_gate(struct clk *clk, int enable)
>>>                             in_v2, out);
>>>        int ret;
>>>    +    /*
>>> +     * In scmi_clk_probe(), in case of CLK_CCF is set, SCMI clock
>>> +     * version is set in dev's parent priv struct. Otherwise
>>> +     * SCMI clock version is set in dev priv struct.
>>> +     */
>>> +    if (CONFIG_IS_ENABLED(CLK_CCF))
>>> +        priv = dev_get_parent_priv(clk->dev);
>>> +    else
>>> +        priv = dev_get_priv(clk->dev);
>> On your hardware, do you have CCF enabled or not ?
> 
> On stm32mp15, CCF is not set.
> 
>>
>> What does this print output if added here ?
>>
>> printf("clk->dev->name=%s clk->dev->parent->name=%s\n", clk->dev->name, clk->dev->parent->name);
>>
>> I think it should be something like this:
>>
>> clk->dev->name=scmi-325 clk->dev->parent->name=protocol at 14
> 
> I got
> 
> clk->dev->name=protocol at 14 clk->dev->parent->name=scmi

I see.

Reviewed-by: Marek Vasut <marek.vasut+renesas at mailbox.org>


More information about the U-Boot mailing list