[PATCH] boot: fix missing dependency for BOOTMETH_ANDROID
Kory Maincent
kory.maincent at bootlin.com
Thu Dec 18 15:11:21 CET 2025
On Thu, 18 Dec 2025 13:19:07 +0100
Quentin Schulz <foss+uboot at 0leil.net> wrote:
> From: Quentin Schulz <quentin.schulz at cherry.de>
>
> The code depends on set_avendor_bootimg_addr and set_abootimg_addr
> functions which are only defined in cmd/abootimg.c, only built when
> CMD_ABOOTIMG=y so let's add a dependency.
>
> It should be "depends on" to be properly implemented, but we get a
> circular dependency otherwise:
> boot/Kconfig:566:error: recursive dependency detected!
> boot/Kconfig:566: symbol BOOTMETH_ANDROID depends on CMD_ABOOTIMG
> cmd/Kconfig:504: symbol CMD_ABOOTIMG depends on ANDROID_BOOT_IMAGE
> boot/Kconfig:7: symbol ANDROID_BOOT_IMAGE is selected by
> BOOTMETH_ANDROID
>
> so instead we do a select. It is safe because CMD_ABOOTIMG depends on
> ANDROID_BOOT_IMAGE which we select here as well.
>
> Fixes: 125d9f3306ea ("bootstd: Add a bootmeth for Android")
> Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
Reviewed-by: Kory Maincent <kory.maincent at bootlin.com>
Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
More information about the U-Boot
mailing list