Re: [PATCH v2 2/3] doc: cmd: bdinfo: specify required dependency for some info

[Quentin Schulz]

On December 20, 2025 12:10:48 AM GMT+01:00, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>On 12/18/25 12:44, Quentin Schulz wrote:
>> From: Quentin Schulz <quentin.schulz at cherry.de>
>> 
>> The devicetree, current eth and IP addr info are only available when
>> certain symbols are defined, so let's make the dependencies explicit.
>> 
>> Signed-off-by: Quentin Schulz <quentin.schulz at cherry.de>
>> ---
>>   doc/usage/cmd/bdinfo.rst | 6 ++++++
>>   1 file changed, 6 insertions(+)
>> 
>> diff --git a/doc/usage/cmd/bdinfo.rst b/doc/usage/cmd/bdinfo.rst
>> index a139c9d855c..2a5873a400a 100644
>> --- a/doc/usage/cmd/bdinfo.rst
>> +++ b/doc/usage/cmd/bdinfo.rst
>> @@ -77,9 +77,13 @@ Build
>>   current eth
>>       name of the active network device
>>   +    Only shown if CONFIG_NET=y or CONFIG_NET_LWIP=y.
>
>Thank you for updating the documentation.
>
>I think we should get rid of all of this CONFIG_NET || CONFIG_NET_LWIP stuff and have a single symbol identifying network support in future.
>
>For maintainability and readability I would prefer
>
>"Only shown if network support is enabled."
>

Good thing I wasn't the only one bothered by this :) I'm working on something but it'll have to wait for me to return from holidays for it to be sent to the ML. If you want a sneak peek: https://source.denx.de/u-boot/contributors/qschulz/u-boot/-/tree/b4/net-kconfig

I prefer to make this separate from this series so this isn't blocked by a big series (big not in terms of patches but in terms of modified files).

>
>
>> +
>>   IP addr
>>       network address, value of the environment variable *ipaddr*
>>   +    Only shown if CONFIG_NET=y or CONFIG_NET_LWIP=y.
>
>ditto
>
>> +
>>   fdt_blob
>>       address of U-Boot's own device tree, NULL if none
>>   @@ -95,6 +99,8 @@ lmb_dump_all
>
>The LMB information of course depends on CONFIG_LMB=y.
>

Indeed, missed that.

>>   devicetree
>>       source of the device-tree
>>   +    Only shown if CONFIG_LMB=y and CONFIG_OF_REAL=y.
>
>The dependency of the devicetree output on LMB is a bug in cmd/bdinfo.c and should be fixed.
>

Will try to fix that. Seems like it was introduced in https://source.denx.de/u-boot/contributors/qschulz/u-boot/-/commit/85007da94bad2d27e40e0258fa5437a35034ee1d so probably an oversight.

Note that we're missing a few "fields" as displayed by this command. E.g. whenever VIDEO, DM_SERIAL, MULTI_DTB_FIT and CMD_BDINFO_EXTRA are set.

Cheers,
Quentin
Hi Heinrich,