[PATCH v1] fix PL330 CMD supported target

[Sune Brian]

Hi Tom,

On Tue, Dec 23, 2025 at 12:08 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Mon, Dec 22, 2025 at 11:10:32PM +0800, Sune Brian wrote:
> > Hi Tom,
> >
> > On Mon, Dec 22, 2025 at 10:56 PM Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Mon, Dec 22, 2025 at 10:27:44PM +0800, Brian Sune wrote:
> > >
> > > > The config is wrongly written, result
> > > > in only support socdk board.
> > > >
> > > > Fixes: 92dcb3ad5d98 ("cmd/dma: implement dmareset command")
> > > > Signed-off-by: Brian Sune <briansune at gmail.com>
> > > > ---
> > > >  cmd/Kconfig | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > > > index 5b9c13d85e7..5c611fb3016 100644
> > > > --- a/cmd/Kconfig
> > > > +++ b/cmd/Kconfig
> > > > @@ -1849,7 +1849,7 @@ menu "Shell scripting commands"
> > > >
> > > >  config CMD_C5_PL330_DMA
> > > >       bool "Release Reset DMA Channels for PL330 Handshake"
> > > > -     depends on TARGET_SOCFPGA_CYCLONE5_SOCDK
> > > > +     depends on TARGET_SOCFPGA_CYCLONE5
> > > >       help
> > > >         Provides access to Reset Manager Per2ModRst. Enables DMA
> > > >         channels for ARM PrimeCell PL330 via reset release.
> > >
> > > Now that I see how mach-socfpga is abusing the TARGET namespace, I get
> > > why this patch is needed, so:
> > >
> > > Reviewed-by: Tom Rini <trini at konsulko.com>
> > >
> > > But really TARGET_SOCFPGA_CYCLONE5 should be "SOCFPGA_CYCLONE5" or
> > > something as it's not a board to build for.
> >
> > How to properly improve or fix these TARGET things?
>
> Well, the TARGET namespace is for machines / boards / what-have-you that
> we're building U-Boot for. Symbols that designate architecture or SoC
> generally just say their name, hence my thinking "SOCFPGA_CYCLONE5" for
> what to me looks like the architecture family of Cyclone V and the
> things common to all platforms. And TARGET_SOCFPGA_GEN5 should become

That is completely correct; it should be grouped as GEN5 - Cyclone V + Arria 5.
But I had no power to fully turn those from this situation.

> SOCFPGA_GEN5, or maybe omitted entirely (and it all goes under
> SOCFPGA_CYCLONE5), I don't know the parts well enough to say what makes
> sense there.
>
> --
> Tom

Brian