Re: [PATCH v2 1/3] test: env: Add test for environment storage in SPI NOR

[Heinrich Schuchardt]

Am 23. Dezember 2025 19:55:45 MEZ schrieb Marek Vasut <marek.vasut at mailbox.org>:
>On 12/23/25 6:32 PM, Heinrich Schuchardt wrote:
>> On 12/23/25 15:31, Marek Vasut wrote:
>>> Add test for environment stored in SPI NOR. The test works in a very
>>> similar way to the current test for environment stored in ext4 FS,
>>> except it generates spi.bin file backing the SPI NOR.
>>> 
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
>>> ---
>>> Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>> Cc: Jerome Forissier <jerome.forissier at linaro.org>
>>> Cc: Simon Glass <sjg at chromium.org>
>>> Cc: Tom Rini <trini at konsulko.com>
>>> Cc: u-boot at lists.denx.de
>>> ---
>>> V2: No change
>>> ---
>>>   test/py/tests/test_env.py | 99 +++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 99 insertions(+)
>>> 
>>> diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py
>>> index 383e26c03b0..48e31f19b3c 100644
>>> --- a/test/py/tests/test_env.py
>>> +++ b/test/py/tests/test_env.py
>>> @@ -457,6 +457,26 @@ def mk_env_ext4(state_test_env):
>>>       utils.run_and_log(c, ['cp',  '-f', persistent, fs_img])
>>>       return fs_img
>>> +def mk_env_spi_flash(state_test_env):
>> 
>> Thank you for adding the test.
>> 
>> Unfortunately pylint doesn't like your code. Please have a look.
>
>Is this something we run in CI ? If so, CI builds did pass.
>
>If not, how do I trigger this ?

I just ran pylint from the command line.

Best regards 

Heinrich