回复: [PATCH v1 3/7] usb: ehci-mx6: Extract PHY initialization into reusable function

[Alice Guo (OSS)]

> -----邮件原件-----
> 发件人: Marek Vasut <marek.vasut at mailbox.org>
> 发送时间: 2025年12月16日 19:18
> 收件人: Alice Guo (OSS) <alice.guo at oss.nxp.com>; dl-uboot-imx
> <uboot-imx at nxp.com>; u-boot at lists.denx.de
> 抄送: Stefano Babic <sbabic at nabladev.com>; Fabio Estevam
> <festevam at gmail.com>; Tom Rini <trini at konsulko.com>; Marek Vasut
> <marex at denx.de>; Marek Vasut <marek.vasut at mailbox.org>; Ye Li
> <ye.li at nxp.com>; tharvey at gateworks.com; Peng Fan <peng.fan at nxp.com>;
> Mattijs Korpershoek <mkorpershoek at kernel.org>; Lukasz Majewski
> <lukma at denx.de>; Sherry Sun <sherry.sun at nxp.com>; Kever Yang
> <kever.yang at rock-chips.com>; Jonas Karlman <jonas at kwiboo.se>; Quentin
> Schulz <quentin.schulz at cherry.de>; George Chan <gchan9527 at gmail.com>;
> Simon Glass <sjg at chromium.org>; David Zang <davidzangcs at gmail.com>; Alice
> Guo <alice.guo at nxp.com>
> 主题: Re: [PATCH v1 3/7] usb: ehci-mx6: Extract PHY initialization into reusable
> function
> 
> On 12/16/25 7:38 AM, alice.guo at oss.nxp.com wrote:
> > From: Alice Guo <alice.guo at nxp.com>
> >
> > Extract USB PHY initialization code from ehci-mx6.c into a new
> > function
> > ehci_mx6_phy_init() that can be shared with the ChipIdea UDC driver.
> >
> > Signed-off-by: Alice Guo <alice.guo at nxp.com>
> > ---
> >   drivers/usb/host/ehci-mx6.c | 73
> ++++++++++++++++++++++++++++++++++++++++++++-
> >   include/usb/ci_udc.h        |  9 ++++++
> >   2 files changed, 81 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
> > index 03ff4ce10d5..52f14e6eca0 100644
> > --- a/drivers/usb/host/ehci-mx6.c
> > +++ b/drivers/usb/host/ehci-mx6.c
> > @@ -12,6 +12,7 @@
> >   #include <asm/global_data.h>
> >   #include <linux/compiler.h>
> >   #include <linux/delay.h>
> > +#include <usb/ci_udc.h>
> >   #include <usb/ehci-ci.h>
> >   #include <asm/io.h>
> >   #include <asm/arch/imx-regs.h>
> > @@ -168,6 +169,54 @@ static void __maybe_unused
> >   usb_power_config_mx7ulp(void *usbphy) { }
> >   #endif
> >
> > +#if defined(CONFIG_IMX8)
> 
> Can we avoid more ifdeffery ?

Thanks for your feedback. I will remove it in the next version.

Best Regards,
Alice Guo