回复: [PATCH v1 5/7] usb: Kconfig: imply DM_USB_GADGET

[Tom Rini]

On Thu, Dec 25, 2025 at 10:16:29AM +0000, Alice Guo (OSS) wrote:
> > -----邮件原件-----
> > 发件人: Quentin Schulz <quentin.schulz at cherry.de>
> > 发送时间: 2025年12月16日 17:50
> > 收件人: Alice Guo (OSS) <alice.guo at oss.nxp.com>; dl-uboot-imx
> > <uboot-imx at nxp.com>; u-boot at lists.denx.de
> > 抄送: Stefano Babic <sbabic at nabladev.com>; Fabio Estevam
> > <festevam at gmail.com>; Tom Rini <trini at konsulko.com>; Marek Vasut
> > <marex at denx.de>; Marek Vasut <marek.vasut at mailbox.org>; Ye Li
> > <ye.li at nxp.com>; tharvey at gateworks.com; Peng Fan <peng.fan at nxp.com>;
> > Mattijs Korpershoek <mkorpershoek at kernel.org>; Lukasz Majewski
> > <lukma at denx.de>; Sherry Sun <sherry.sun at nxp.com>; Kever Yang
> > <kever.yang at rock-chips.com>; Jonas Karlman <jonas at kwiboo.se>; George
> > Chan <gchan9527 at gmail.com>; Simon Glass <sjg at chromium.org>; David Zang
> > <davidzangcs at gmail.com>; Alice Guo <alice.guo at nxp.com>
> > 主题: Re: [PATCH v1 5/7] usb: Kconfig: imply DM_USB_GADGET
> > 
> > Hi Alice,
> > 
> > On 12/16/25 7:38 AM, alice.guo at oss.nxp.com wrote:
> > > From: Sherry Sun <sherry.sun at nxp.com>
> > >
> > > Since the ci_udc driver has been converted to DM driver, the
> > > CONFIG_DM_USB_GADGET should also be selected when CONFIG_CI_UDC is
> > > enabled, then we can use DM ci_udc driver.
> > >
> > 
> > Is DM_USB_GADGET *required* for CI_UDC to work? "imply" allows to have
> > DM_USB_GADGET=y AND CI_UDC=n, which is probably not what you want. You
> > probably simply want "depends on DM_USB_GADGET"
> 
> There are 2 implementations supported in drivers/usb/gadget/ci_udc.c: a non-DM path and a DM-based path. The current commit log wording might be ambiguous.

OK. But the key here is that we shouldn't keep code around for the case
of both non-DM and full U-Boot. It's valid to have non-DM and xPL, or DM
and xPL or DM and full U-Boot. We just need to be clear and sure that
we're doing this in both code and commit message.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20251225/4486ba8c/attachment.sig>