[PATCH v2 4/7] video: imx: ipuv3: fix camel cases

Brian Ruley brian.ruley at gehealthcare.com
Mon Dec 29 11:48:04 CET 2025


U-Boot style specifies to use snake case and checkpatch nudge to check
them every time.

Signed-off-by: Brian Ruley <brian.ruley at gehealthcare.com>
---

(no changes since v1)

 drivers/video/imx/ipu.h          | 10 +++++-----
 drivers/video/imx/ipu_common.c   | 12 ++++++------
 drivers/video/imx/ipu_disp.c     |  6 +++---
 drivers/video/imx/mxc_ipuv3_fb.c |  4 ++--
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/video/imx/ipu.h b/drivers/video/imx/ipu.h
index 83cd0d8470e..16e103cf541 100644
--- a/drivers/video/imx/ipu.h
+++ b/drivers/video/imx/ipu.h
@@ -194,11 +194,11 @@ typedef struct {
 	unsigned data_pol : 1; /* true = inverted */
 	unsigned clk_pol : 1; /* true = rising edge */
 	unsigned enable_pol : 1;
-	unsigned Hsync_pol : 1; /* true = active high */
-	unsigned Vsync_pol : 1;
+	unsigned hsync_pol : 1; /* true = active high */
+	unsigned vsync_pol : 1;
 } ipu_di_signal_cfg_t;
 
-typedef enum { RGB, YCbCr, YUV } ipu_color_space_t;
+typedef enum { RGB, YCBCR, YUV } ipu_color_space_t;
 
 /* Common IPU API */
 int32_t ipu_init_channel(ipu_channel_t channel, ipu_channel_params_t *params);
@@ -211,7 +211,7 @@ int32_t ipu_init_channel_buffer(ipu_channel_t channel, ipu_buffer_t type,
 				u32 v_offset);
 
 void ipu_clear_buffer_ready(ipu_channel_t channel, ipu_buffer_t type,
-			    u32 bufNum);
+			    u32 buf_num);
 int32_t ipu_enable_channel(ipu_channel_t channel);
 int32_t ipu_disable_channel(ipu_channel_t channel);
 
@@ -224,7 +224,7 @@ int32_t ipu_init_sync_panel(int disp, u32 pixel_clk, u16 width, u16 height,
 int32_t ipu_disp_set_global_alpha(ipu_channel_t channel, unsigned char enable,
 				  u8 alpha);
 int32_t ipu_disp_set_color_key(ipu_channel_t channel, unsigned char enable,
-			       u32 colorKey);
+			       u32 color_key);
 
 u32 bytes_per_pixel(u32 fmt);
 
diff --git a/drivers/video/imx/ipu_common.c b/drivers/video/imx/ipu_common.c
index 78bff87097e..6ce44e42349 100644
--- a/drivers/video/imx/ipu_common.c
+++ b/drivers/video/imx/ipu_common.c
@@ -273,10 +273,10 @@ static inline int ipu_is_dmfc_chan(u32 dma_chan)
 	return ((dma_chan >= 23) && (dma_chan <= 29));
 }
 
-static inline void ipu_ch_param_set_buffer(u32 ch, int bufNum,
+static inline void ipu_ch_param_set_buffer(u32 ch, int buf_num,
 					   dma_addr_t phyaddr)
 {
-	ipu_ch_param_mod_field(ipu_ch_param_addr(ch), 1, 29 * bufNum, 29,
+	ipu_ch_param_mod_field(ipu_ch_param_addr(ch), 1, 29 * buf_num, 29,
 			       phyaddr / 8);
 };
 
@@ -1075,12 +1075,12 @@ int32_t ipu_enable_channel(ipu_channel_t channel)
  *
  * @param	type		Input parameter which buffer to clear.
  *
- * @param	bufNum		Input parameter for which buffer number clear
+ * @param	buf_num		 Input parameter for which buffer number clear
  *				ready state.
  *
  */
 void ipu_clear_buffer_ready(ipu_channel_t channel, ipu_buffer_t type,
-			    u32 bufNum)
+			    u32 buf_num)
 {
 	u32 dma_ch = channel_2_dma(channel, type);
 
@@ -1088,7 +1088,7 @@ void ipu_clear_buffer_ready(ipu_channel_t channel, ipu_buffer_t type,
 		return;
 
 	__raw_writel(0xF0000000, IPU_GPR); /* write one to clear */
-	if (bufNum == 0) {
+	if (buf_num == 0) {
 		if (idma_is_set(IPU_CHA_BUF0_RDY, dma_ch)) {
 			__raw_writel(idma_mask(dma_ch),
 				     IPU_CHA_BUF0_RDY(dma_ch));
@@ -1212,7 +1212,7 @@ ipu_color_space_t format_to_colorspace(u32 fmt)
 		break;
 
 	default:
-		return YCbCr;
+		return YCBCR;
 		break;
 	}
 	return RGB;
diff --git a/drivers/video/imx/ipu_disp.c b/drivers/video/imx/ipu_disp.c
index af6daec7f64..89dead372cd 100644
--- a/drivers/video/imx/ipu_disp.c
+++ b/drivers/video/imx/ipu_disp.c
@@ -1090,9 +1090,9 @@ int32_t ipu_init_sync_panel(int disp, u32 pixel_clk, u16 width, u16 height,
 			ipu_dc_write_tmpl(7, WROD(0), 0, map, SYNC_WAVE, 0, 5);
 		}
 
-		if (sig.Hsync_pol)
+		if (sig.hsync_pol)
 			di_gen |= DI_GEN_POLARITY_2;
-		if (sig.Vsync_pol)
+		if (sig.vsync_pol)
 			di_gen |= DI_GEN_POLARITY_3;
 
 		if (!sig.clk_pol)
@@ -1181,7 +1181,7 @@ int32_t ipu_disp_set_global_alpha(ipu_channel_t channel, unsigned char enable,
  *
  * @param	enable		Boolean to enable or disable color key
  *
- * @param	colorKey	24-bit RGB color for transparent color key.
+ * @param	color_key	 24-bit RGB color for transparent color key.
  *
  * Return:	Returns 0 on success or negative error code on fail
  */
diff --git a/drivers/video/imx/mxc_ipuv3_fb.c b/drivers/video/imx/mxc_ipuv3_fb.c
index 6c271490ba1..fb9d364d23a 100644
--- a/drivers/video/imx/mxc_ipuv3_fb.c
+++ b/drivers/video/imx/mxc_ipuv3_fb.c
@@ -211,9 +211,9 @@ static int mxcfb_set_par(struct fb_info *fbi)
 	if ((fbi->var.sync & FB_SYNC_EXT) || ext_clk_used)
 		sig_cfg.ext_clk = 1;
 	if (fbi->var.sync & FB_SYNC_HOR_HIGH_ACT)
-		sig_cfg.Hsync_pol = 1;
+		sig_cfg.hsync_pol = 1;
 	if (fbi->var.sync & FB_SYNC_VERT_HIGH_ACT)
-		sig_cfg.Vsync_pol = 1;
+		sig_cfg.vsync_pol = 1;
 	if (!(fbi->var.sync & FB_SYNC_CLK_LAT_FALL))
 		sig_cfg.clk_pol = 1;
 	if (fbi->var.sync & FB_SYNC_DATA_INVERT)
-- 
2.39.5



More information about the U-Boot mailing list