[PATCH] clk: versal: Store driver data in data section

[Michal Simek]

On 2/18/25 06:24, Padmarao Begari wrote:
> Line 171 in README is describing that before relocation
> no code should use global variable because global variables
> are placed to BSS section which is initialized to 0 after
> relocation.
> 
> On Versal platforms clock driver is initialized before
> relocation (via using dm,bootph-all flag in DT) and global
> variables are initialized which works if this is used only
> before relocation. But the variables are used after
> relocation too but values are zeroed which is ending up
> incorrect behavior.
> 
> That's why place variables to data section to ensure that
> values are not cleared which is for now the quickest
> temporary solution. The correct way to do it is to move
> all global variables to private data to avoid it.
> 
> Signed-off-by: Padmarao Begari <padmarao.begari at amd.com>
> ---
>   drivers/clk/clk_versal.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/clk_versal.c b/drivers/clk/clk_versal.c
> index 35ee56d0693..675bdb7ac0e 100644
> --- a/drivers/clk/clk_versal.c
> +++ b/drivers/clk/clk_versal.c
> @@ -106,8 +106,8 @@ struct versal_clk_priv {
>   	struct versal_clock *clk;
>   };
>   
> -static ulong pl_alt_ref_clk;
> -static ulong ref_clk;
> +static ulong pl_alt_ref_clk __section(".data");
> +static ulong ref_clk __section(".data");
>   
>   struct versal_pm_query_data {
>   	u32 qid;
> @@ -116,8 +116,8 @@ struct versal_pm_query_data {
>   	u32 arg3;
>   };
>   
> -static struct versal_clock *clock;
> -static unsigned int clock_max_idx;
> +static struct versal_clock *clock __section(".data");
> +static unsigned int clock_max_idx __section(".data");
>   
>   #define PM_QUERY_DATA	35
>   

Applied.
M