[PATCH] sandbox: Adjust configuration to hang on panic()

[Simon Glass]

Hi Heinrich,

On Thu, 2 Jan 2025 at 00:32, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> On 12/20/24 04:59, Simon Glass wrote:
> > It is annoying to have sandbox enter a boot loop when an assertion
> > fails. Hang instead, since then the error message is only printed once
> > and Ctrl-C can be used to quit, as per normal.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >   configs/sandbox_defconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
> > index 3de4aa79c6d..636130a360d 100644
> > --- a/configs/sandbox_defconfig
> > +++ b/configs/sandbox_defconfig
> > @@ -354,6 +354,7 @@ CONFIG_WDT_FTWDT010=y
> >   CONFIG_FS_CBFS=y
> >   CONFIG_FS_CRAMFS=y
> >   CONFIG_ADDR_MAP=y
> > +CONFIG_PANIC_HANG=y
>
> Command line option -S is used for running the UEFI SCT. We need the
> sandbox to reboot and to allow the SCT to report the failed test.

What is causing it to panic in this case?

>
> This patch is not needed. You can already exit the assertion caused loop
> with CTRL-C.

Right, but this creates a continuous stream of output.

I suppose we could add a command-line flag to reboot on panic, but I
would like to understand the mechanism.

Can you please add something to doc/ about how to run this with
sandbox, including which build/commit of EDK2 works on x86_64? I was
never quite able to get this running with sandbox.

>
> >   CONFIG_CMD_DHRYSTONE=y
> >   CONFIG_MBEDTLS_LIB=y
> >   CONFIG_ECDSA=y
>

Regards,
Simon