回复: [EXT] Re: [PATCH v2 16/17] imx95_evk: add i.MX95 19x19 EVK board basic support

[Alice Guo (OSS)]

> -----邮件原件-----
> 发件人: Tim Harvey <tharvey at gateworks.com>
> 发送时间: 2025年1月3日 7:13
> 收件人: Alice Guo (OSS) <alice.guo at oss.nxp.com>
> 抄送: Tom Rini <trini at konsulko.com>; Stefano Babic <sbabic at denx.de>; Fabio
> Estevam <festevam at gmail.com>; dl-uboot-imx <uboot-imx at nxp.com>; Lukasz
> Majewski <lukma at denx.de>; Sean Anderson <seanga2 at gmail.com>; Simon
> Glass <sjg at chromium.org>; Alper Nebi Yasak <alpernebiyasak at gmail.com>;
> u-boot at lists.denx.de; marex at denx.de; Alice Guo <alice.guo at nxp.com>; Ye Li
> <ye.li at nxp.com>; Peng Fan <peng.fan at nxp.com>
> 主题: [EXT] Re: [PATCH v2 16/17] imx95_evk: add i.MX95 19x19 EVK board
> basic support
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Thu, Dec 19, 2024 at 6:57 PM Alice Guo <alice.guo at oss.nxp.com> wrote:
> >
> > From: Ye Li <ye.li at nxp.com>
> >
> > This patch adds i.MX95 19x19 EVK board basic support.
> >
> > Signed-off-by: Ye Li <ye.li at nxp.com>
> > Signed-off-by: Alice Guo <alice.guo at nxp.com>
> > Reviewed-by: Peng Fan <peng.fan at nxp.com>
> > ---
> >  arch/arm/dts/imx95-19x19-evk-u-boot.dtsi      | 224
> ++++++++++++++++++++++++++
> >  arch/arm/mach-imx/imx9/Kconfig                |   6 +
> >  arch/arm/mach-imx/imx9/scmi/container.cfg     |  10 ++
> >  arch/arm/mach-imx/imx9/scmi/imximage.cfg      |  15 ++
> >  arch/arm/mach-imx/imx9/scmi/soc.c             |   1 +
> >  board/freescale/imx95_evk/Kconfig             |  12 ++
> >  board/freescale/imx95_evk/MAINTAINERS         |   6 +
> >  board/freescale/imx95_evk/Makefile            |  11 ++
> >  board/freescale/imx95_evk/imx95_19x19_evk.env |  95 +++++++++++
> >  board/freescale/imx95_evk/imx95_evk.c         |  54 +++++++
> >  board/freescale/imx95_evk/spl.c               | 117 ++++++++++++++
> >  configs/imx95_19x19_evk_defconfig             | 178
> ++++++++++++++++++++
> >  doc/board/nxp/imx95_evk.rst                   | 109 +++++++++++++
> >  doc/board/nxp/index.rst                       |   1 +
> >  include/configs/imx95_evk.h                   |  36 +++++
> >  15 files changed, 875 insertions(+)
> >
> 
> Hi Alice,
> 
> I found some issues with imx95_19x19_evk.env (see below)
> 
> <snip>
> > diff --git a/board/freescale/imx95_evk/imx95_19x19_evk.env
> > b/board/freescale/imx95_evk/imx95_19x19_evk.env
> > new file mode 100644
> > index
> >
> 0000000000000000000000000000000000000000..27e09d3d70a068efb97d6
> 9b27089
> > d1f213f39ee9
> > --- /dev/null
> > +++ b/board/freescale/imx95_evk/imx95_19x19_evk.env
> > @@ -0,0 +1,95 @@
> > +sec_boot=no
> > +initrd_addr=0x93800000
> > +emmc_dev=0
> > +sd_dev=1
> > +prepare_mcore=setenv mcore_clk clk-imx95.mcore_booted
> 
> I see where mcore_clk is used but nothing uses prepare_mcore. Also there is
> no upstream Linux clk-imx95 driver yet so this really doesn't do anything
> useful. Has a clk-imx95 driver been submitted?

Hi Tim,

i.MX95 use clk-scmi.c driver, so no clk-imx95. And there is no prepare_mcore, this env needs to be dropped.

Thanks for pointing out my errors. I will correct them.

Best Regards,
Alice Guo