[PATCH 08/67] x86: Emable meminfo command

[Simon Glass]

Hi Heinrich,

On Sat, 4 Jan 2025 at 03:51, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> Nits:
> %s/Emable/Enable/
>
> On 01.01.25 23:08, Simon Glass wrote:
> > Enable this command for x86 boards as it is quite useful for seeing
> > where memory is.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
>
> Enabling the option by default for the sandbox in cmd/Kconfig and for
> x86 in arch/Kconfig is confusing. Please, use the same approach for all
> concerned architectures.

OK.

>
> Why do we need symbol CMD_MEMINFO_MAP? The meminfo command is worthless
> without it. Both the greeting header and bdinfo already show the memory
> size. Can we remove that over-engineering?

I have no objection to that, but please check with Tom and Ilias[1] [2]

>
> Sending standalone patches separately from a bulky patch series would
> avoid hesitation to review and merge (see Tom's mail).

Well, thank you for reviewing. I'm going to figure out some tooling to
help, when I get a chance. Then I hope to be able to keep track of
lots of independent patches. Tom has suggested that I just send less,
as well. Another solution might be for me to adopt several aliases so
I am three different people?

Regards,
Simon

[1] https://patchwork.ozlabs.org/project/uboot/patch/20241011214032.760072-7-sjg@chromium.org/
[2] https://patchwork.ozlabs.org/project/uboot/patch/20241009015020.25817-7-sjg@chromium.org/