[PATCH v2] watchdog: rti: drop hack manipulating WDT clock rate
Stefan Roese
sr at denx.de
Tue Jan 7 10:26:55 CET 2025
On 21.11.24 09:03, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin at siemens.com>
>
> The hack itself seems to be copied from Linux rti_wdt.c, but the WDT reset
> principle is different in U-Boot. While Linux relies on correct frequencies
> and timers and doesn't check the actual WDT counter value U-Boot driver
> seems to be more robust: it does compare RTIDWDCNTR vs RTIDWDPRLD.
>
> Now the root cause of the original motivation to manipulate the clock rate
> is said to be understood and fixed in Linux commit cae58516534e
> ("watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin")
> which simultaneously removed the hack itself.
>
> While is fix part of the mentioned patch is neither applicable nor requried
> for the U-Boot driver just drop the hack setting WDT clock rate to 90% of
> the real rate. This has a nice effect that the WDT timeout is now as
> requested and not 10% shorter.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin at siemens.com>
> Reviewed-by: Jan Kiszka <jan.kiszka at siemens.com>
> ---
> Changelog:
> v2: 2 typos pointed by Jan corrected
Reviewed-by: Stefan Roese <sr at denx.de>
Thanks,
Stefan
More information about the U-Boot
mailing list