Re: 回复: [EXT] Re: [PATCH v3 07/17] clk: scmi: check the clock state/parent/rate control permissions

[Marek Vasut]

On 1/7/25 9:00 AM, Alice Guo (OSS) wrote:
>>> SCMI clock management protocol driver in Linux checks clock state,
>>> parent and rate control permissions. To be consistent with the kernel
>>> driver, add this check here.
>>>
>>> When using common clock framework (CCF), use the clock signal ID to
>>> get the clock registered by clk_register() in scmi_clk_probe(), and
>>> then obatin the struct clk_scmi variable with container_of().
>>>
>>> Signed-off-by: Alice Guo <alice.guo at nxp.com>
>>> Signed-off-by: Ye Li <ye.li at nxp.com>
>>> Reviewed-by: Peng Fan <peng.fan at nxp.com>
>>> ---
>>>    arch/sandbox/include/asm/scmi_test.h       |   2 +
>>>    drivers/clk/clk_scmi.c                     | 173
>> +++++++++++++++++++++++++++--
>>>    drivers/firmware/scmi/sandbox-scmi_agent.c |  56 +++++++++-
>>>    include/scmi_protocols.h                   |  26 ++++-
>> Please split common/imx/sandbox changes into separate patches .
> 
> Spliting common/imx/sandbox changes into separate patches will cause bisect issue.

How so ?