[PATCH v2 1/3] serial: ns16550: Add Intel XScale support

[Stefan Roese]

On 31.12.24 17:49, Duje Mihanović wrote:
> Add compatible string for the Intel XScale variant of the 16550. Needed
> to match upstream.
> 
> Signed-off-by: Duje Mihanović <duje.mihanovic at skole.hr>
>
> ---
>   drivers/serial/ns16550.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index 3f6860f39162df74c3d1f03d3f9aa90090216646..eab193395087877d2a8da38e1b4daabf46e81f2f 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -614,6 +614,7 @@ static const struct udevice_id ns16550_serial_ids[] = {
>   	{ .compatible = "ingenic,jz4780-uart",	.data = PORT_JZ4780  },
>   	{ .compatible = "nvidia,tegra20-uart",	.data = PORT_NS16550 },
>   	{ .compatible = "snps,dw-apb-uart",	.data = PORT_NS16550 },
> +	{ .compatible = "intel,xscale-uart",	.data = PORT_NS16550 },

Looking at the Linux 8250 of_device_id struct I see this entry:

	{ .compatible = "mrvl,mmp-uart",
		.data = (void *)PORT_XSCALE, },

Wouldn't it make more sense to use this compatible property instead?

Thanks,
Stefan