[PATCH 12/15] mach-snapdragon: move memory parsing to its own file
Simon Glass
sjg at chromium.org
Tue Jan 7 16:32:22 CET 2025
Hi Caleb,
On Sun, 24 Nov 2024 at 12:18, Caleb Connolly <caleb.connolly at linaro.org> wrote:
>
> This code is getting a bit complicated, split it out to try and keep
> things a bit better organised as we're going to be supporting populating
> the memory layout from various other sources.
>
> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>
> ---
> arch/arm/mach-snapdragon/Makefile | 2 +-
> arch/arm/mach-snapdragon/board.c | 94 ----------------------------
> arch/arm/mach-snapdragon/dram.c | 116 +++++++++++++++++++++++++++++++++++
> arch/arm/mach-snapdragon/qcom-priv.h | 2 +
> 4 files changed, 119 insertions(+), 95 deletions(-)
Reviewed-by: Simon Glass <sjg at chromium.org>
But please comment the function in the header file:
> diff --git a/arch/arm/mach-snapdragon/qcom-priv.h b/arch/arm/mach-snapdragon/qcom-priv.h
> index 74d39197b89f..b7f3bf798d3c 100644
> --- a/arch/arm/mach-snapdragon/qcom-priv.h
> +++ b/arch/arm/mach-snapdragon/qcom-priv.h
> @@ -22,5 +22,7 @@ static inline void qcom_of_fixup_nodes(void)
> log_debug("Unable to dynamically fixup USB nodes, please enable CONFIG_OF_LIVE\n");
> }
> #endif /* OF_LIVE */
>
> +void qcom_parse_memory(void);
> +
> #endif /* __QCOM_PRIV_H__ */
>
> --
> 2.47.0
>
Regards,
Simon
More information about the U-Boot
mailing list