[PATCH 02/15] vbe: Split out reading a FIT into a common file

Tom Rini trini at konsulko.com
Sat Jan 11 23:54:33 CET 2025


On Thu, Jan 09, 2025 at 05:29:57AM -0700, Simon Glass wrote:

> Loading a FIT is useful for other VBE methods, such as ABrec. Create a
> new function to handling reading it.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

This causes a bunch of growth:
            a3y17lte       : all +1328 text +1328
               u-boot: add: 8/0, grow: 1/0 bytes: 1328/0 (1328)
                 function                                   old     new   delta
                 blkcache_fill                                -     332    +332
                 blkcache_read                                -     240    +240
                 blk_read                                     -     188    +188
                 vbe_read_nvdata                              -     156    +156
                 vbe_read_version                             -     140    +140
                 vbe_get_blk                                  -     100    +100
                 simple_read_nvdata                           -      96     +96
                 crc8                                         -      72     +72
                 vbe_simple_read_state                      108     112      +4

Which is unexpected for just moving code around that's not newly used.
And even when it's just a move it's still growing:
            xilinx_zynqmp_virt: all +128 bss -72 text +200
               u-boot: add: 4/0, grow: 0/-1 bytes: 540/-340 (200)
                 function                                   old     new   delta
                 vbe_read_nvdata                              -     156    +156
                 vbe_get_blk                                  -     148    +148
                 vbe_read_version                             -     140    +140
                 simple_read_nvdata                           -      96     +96
                 vbe_simple_read_state                      452     112    -340

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250111/12749bd6/attachment.sig>


More information about the U-Boot mailing list