[PATCH 01/15] vbe: Split out some VBE code into a common file

Tom Rini trini at konsulko.com
Tue Jan 14 02:22:26 CET 2025


On Thu, Jan 09, 2025 at 05:29:56AM -0700, Simon Glass wrote:

> Loading a FIT is useful for other VBE methods, such as ABrec, so start
> a new common file. Add functions for reading the version and nvdata.
> Also add a function to get the block device.

This is not a good commit message when you're also introducing
functional changes (blk_dread -> blk_read). Further, this functional
change seems to introduce some other code being pulled in very
unexpectedly, and that needs to be explained. For example,
phycore_am62x_r5_usbdfu is another case and that has
CONFIG_BLOCK_CACHE=y but CONFIG_SPL_BLOCK_CACHE=n, and yet the size
growth is in full U-Boot. Just moving code should not result in
unexpected size change.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250113/3568f841/attachment.sig>


More information about the U-Boot mailing list