[U-Boot][PATCH 1/2] fpga: fix alignment on fpga cmd usage info

Michal Simek michal.simek at amd.com
Tue Jan 14 08:53:46 CET 2025



On 1/9/25 13:45, Erkiaga Elorza, Ibai wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> 
> Agree Alex,
> 
> I just used /t to stick as much as possible to the current implementation, but 
> I'm open to change to white spaces if Michal thinks it's better.
> 
> Regards
> Ibai
> 
> --------------------------------------------------------------------------------
> *From:* Alexander Dahl <ada at thorsis.com>
> *Sent:* 09 January 2025 07:52
> *To:* Erkiaga Elorza, Ibai <ibai.erkiaga-elorza at amd.com>
> *Cc:* u-boot at lists.denx.de <u-boot at lists.denx.de>; Simek, Michal 
> <michal.simek at amd.com>
> *Subject:* Re: [U-Boot][PATCH 1/2] fpga: fix alignment on fpga cmd usage info
> Caution: This message originated from an External Source. Use proper caution 
> when opening attachments, clicking links, or responding.
> 
> 
> Hello,
> 
> Am Wed, Jan 08, 2025 at 02:03:50PM +0000 schrieb Ibai Erkiaga:
>> The current implementation generates some alignment issues as well as
>> some overlapping when all the fpga command options are enabled. The fix
>> is intended to improve readability of the usage info.
> 
> Alignment could indeed improved.  One question: the \t is dependent on
> the terminal, right?  Would it be better to use spaces instead?  That
> would also make the code more readable.

Agree. Even other commands are using tabs using spaces would be better.

Thanks,
Michal



More information about the U-Boot mailing list