[PATCH 1/8] ARM: renesas: Rename board/renesas/rcar-common to board/renesas/common

Quentin Schulz quentin.schulz at cherry.de
Wed Jan 15 10:58:29 CET 2025


Hi Marek,

On 1/12/25 11:34 PM, Marek Vasut wrote:
> Rename directory board/renesas/rcar-common to board/renesas/common and
> move files. This allows the build system to use HAVE_VENDOR_COMMON_LIB
> which automatically includes board/$(VENDOR)/common/Makefile . This is

Please mention this is NOT sufficient to make use of 
HAVE_VENDOR_COMMON_LIB as board/renesas/common is missing a Makefile.

Something like:

This will allow the build system to use HAVE_VENDOR_COMMON_LIB once a 
Makefile is added in a later commit. This mechanism automatically 
includes board/$(VENDOR)/common/Makefile.

or something like that.

> a preparatory patch for board Makefile simplification. No functional
> change so far.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>

The change is fine, but please make the commit log a bit less confusing 
around the use of HAVE_VENDOR_COMMON_LIB in this commit.

Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

Thanks!
Quentin


More information about the U-Boot mailing list