[PATCH 06/43] test: Add newlines to hush-test messages
Simon Glass
sjg at chromium.org
Wed Jan 15 14:30:36 CET 2025
A few messages lack a newline so the test output shows the next
test-name on the same line. For example:
Beware: this test sets local variable dollar_bar and dollar_quux
and they cannot be unset!Test: hush_test_env_dollar: dollar.c
This is confusing, so fix it.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
test/hush/dollar.c | 7 ++++---
test/hush/loop.c | 4 ++--
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/test/hush/dollar.c b/test/hush/dollar.c
index 077dcd62c0e..820110799a2 100644
--- a/test/hush/dollar.c
+++ b/test/hush/dollar.c
@@ -108,7 +108,7 @@ static int hush_test_simple_dollar(struct unit_test_state *uts)
/* Reset local variable. */
ut_assertok(run_command("dollar_foo=", 0));
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
- puts("Beware: this test set local variable dollar_foo and it cannot be unset!");
+ puts("Beware: this test set local variable dollar_foo and it cannot be unset!\n");
}
return 0;
@@ -140,7 +140,7 @@ static int hush_test_env_dollar(struct unit_test_state *uts)
/* Reset local variable. */
ut_assertok(run_command("env_foo=", 0));
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
- puts("Beware: this test set local variable env_foo and it cannot be unset!");
+ puts("Beware: this test set local variable env_foo and it cannot be unset!\n");
}
return 0;
@@ -206,7 +206,8 @@ static int hush_test_command_dollar(struct unit_test_state *uts)
ut_assertok(run_command("dollar_bar=", 0));
ut_assertok(run_command("dollar_quux=", 0));
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
- puts("Beware: this test sets local variable dollar_bar and dollar_quux and they cannot be unset!");
+ puts("Beware: this test sets local variable dollar_bar and "
+ "dollar_quux and they cannot be unset!\n");
}
return 0;
diff --git a/test/hush/loop.c b/test/hush/loop.c
index a9b6a8edf24..7154b9bc0ae 100644
--- a/test/hush/loop.c
+++ b/test/hush/loop.c
@@ -25,7 +25,7 @@ static int hush_test_for(struct unit_test_state *uts)
/* Reset local variable. */
ut_assertok(run_command("loop_i=", 0));
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
- puts("Beware: this test set local variable loop_i and it cannot be unset!");
+ puts("Beware: this test set local variable loop_i and it cannot be unset!\n");
}
return 0;
@@ -56,7 +56,7 @@ static int hush_test_while(struct unit_test_state *uts)
/* Reset local variable. */
ut_assertok(run_command("loop_foo=", 0));
} else if (gd->flags & GD_FLG_HUSH_OLD_PARSER) {
- puts("Beware: this test set local variable loop_foo and it cannot be unset!");
+ puts("Beware: this test set local variable loop_foo and it cannot be unset!\n");
}
return 0;
--
2.34.1
More information about the U-Boot
mailing list