[PATCH v2 3/4] bloblist: add support for CONFIG_BLOBLIST_PASSAGE

Simon Glass sjg at chromium.org
Thu Jan 16 02:26:58 CET 2025


Hi Harrison,

On Wed, 15 Jan 2025 at 06:53, Harrison Mutai <harrison.mutai at arm.com> wrote:
>
> When the configuration option CONFIG_BLOBLIST_PASSAGE is selected, the
> bloblist present in the incoming standard passage is utilised in-place.
> There is no need to specify the size of the bloblist as the system
> automatically detects it using the header information.
>
> Signed-off-by: Harrison Mutai <harrison.mutai at arm.com>
> ---
>  common/Kconfig    | 8 +++++++-
>  common/bloblist.c | 5 ++++-
>  2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 7a80b797df..49fe04ffca 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -1064,6 +1064,12 @@ config BLOBLIST_ALLOC
>           specify a fixed address on systems where this is unknown or can
>           change at runtime.
>
> +config BLOBLIST_PASSAGE
> +       bool "Use bloblist in-place"
> +       help
> +         Use a bloblist in the incoming standard passage. The size is detected
> +         automatically so CONFIG_BLOBLIST_SIZE can be 0.
> +
>  endchoice
>
>  config BLOBLIST_ADDR
> @@ -1078,6 +1084,7 @@ config BLOBLIST_ADDR
>
>  config BLOBLIST_SIZE
>         hex "Size of bloblist"
> +       default 0x0 if BLOBLIST_PASSAGE
>         default 0x400
>         help
>           Sets the size of the bloblist in bytes. This must include all
> @@ -1088,7 +1095,6 @@ config BLOBLIST_SIZE
>  config BLOBLIST_SIZE_RELOC
>         hex "Size of bloblist after relocation"
>         default BLOBLIST_SIZE if BLOBLIST_FIXED || BLOBLIST_ALLOC
> -       default 0x0 if BLOBLIST_PASSAGE
>         default 0x20000 if (ARM && EFI_LOADER && GENERATE_ACPI_TABLE)
>         help
>           Sets the size of the bloblist in bytes after relocation. Since U-Boot
> diff --git a/common/bloblist.c b/common/bloblist.c
> index 110bb9dc44..f52f1eaca9 100644
> --- a/common/bloblist.c
> +++ b/common/bloblist.c
> @@ -475,6 +475,9 @@ int bloblist_reloc(void *to, uint to_size)
>  {
>         struct bloblist_hdr *hdr;
>
> +       if (to_size == 0)

if (!to_size)

> +               return 0;
> +
>         if (to_size < gd->bloblist->total_size)
>                 return -ENOSPC;
>
> @@ -510,7 +513,7 @@ int bloblist_init(void)
>          * install the bloblist passed from previous loader to this fixed
>          * address.
>          */
> -       bool from_boot_arg = fixed && xpl_is_first_phase();
> +       bool from_boot_arg = xpl_is_first_phase();
>
>         if (xpl_prev_phase() == PHASE_TPL && !IS_ENABLED(CONFIG_TPL_BLOBLIST))
>                 from_addr = false;
> --
> 2.46.2
>

Regards,
Simon


More information about the U-Boot mailing list