[PATCH v3 1/6] arm: imx8m: add OP-TEE node

[Tim Harvey]

On Thu, Jan 16, 2025 at 2:57 PM Fabio Estevam <festevam at gmail.com> wrote:
>
> On Thu, Jan 16, 2025 at 7:45 PM Tim Harvey <tharvey at gateworks.com> wrote:
>
> > Hi Yannic,
> >
> > As I mentioned before, I still don't see how this builds when tee.bin
> > is missing because someone isn't using tee?
> >
> > It looks like Fabio has merged this already to imx/master which now
> > fails to build for imx8m*_venice boards because of it.
>
> make mrproper
> make imx8mp_venice_defconfig
> make
>
> flash.bin is still generated despite this nasty warning:
>
>   CFGS    spl/u-boot-spl.cfgout
>   BINMAN  .binman_stamp
> Image 'image' has faked external blobs and is non-functional: tee.bin
>
> Image 'image' is missing optional external blobs but is still functional: tee-os
>
> /binman/section/fit/images/tee/tee-os (tee.bin):
>    See the documentation for your board. You may need to build Open Portable
>    Trusted Execution Environment (OP-TEE) and build with TEE=/path/to/tee.bin
>
> Some images are invalid
> make: *** [Makefile:1135: .binman_stamp] Error 103
>
> CI also did not complain.

I must admit I don't know much about how CI works but the make process
returns an error status, but you are correct flash.bin exists.

>
> Yes, I would welcome a patch that removes these tee messages by default.

I'm not sure I agree that they should be considered nasty warnings and
removed. What if you intended tee.bin to be included but forgot to
copy it here and you end up with this?

Best Regards,

Tim