[PATCH 5/8] led: Handle return value from cyclic_register()

Marek Vasut marek.vasut+renesas at mailbox.org
Sat Jan 18 05:00:59 CET 2025


Handle the error code returned by cyclic_register() and propagate it.

Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
---
Cc: Aaron Williams <awilliams at marvell.com>
Cc: Anatolij Gustschin <agust at denx.de>
Cc: Angelo Dureghello <angelo at kernel-space.org>
Cc: Christian Marangi <ansuelsmth at gmail.com>
Cc: Devarsh Thakkar <devarsht at ti.com>
Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
Cc: Jaehoon Chung <jh80.chung at samsung.com>
Cc: Michael Polyntsov <michael.polyntsov at iopsys.eu>
Cc: Michael Trimarchi <michael at amarulasolutions.com>
Cc: Nikhil M Jain <n-jain1 at ti.com>
Cc: Peng Fan <peng.fan at nxp.com>
Cc: Peter Robinson <pbrobinson at gmail.com>
Cc: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
Cc: Ronald Wahl <ronald.wahl at legrand.com>
Cc: Simon Glass <sjg at chromium.org>
Cc: Stefan Roese <sr at denx.de>
Cc: Tim Harvey <tharvey at gateworks.com>
Cc: Tom Rini <trini at konsulko.com>
Cc: u-boot at lists.denx.de
---
 drivers/led/led_sw_blink.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/led/led_sw_blink.c b/drivers/led/led_sw_blink.c
index ee1546d02d4..859dac47c30 100644
--- a/drivers/led/led_sw_blink.c
+++ b/drivers/led/led_sw_blink.c
@@ -50,6 +50,7 @@ int led_sw_set_period(struct udevice *dev, int period_ms)
 	struct led_sw_blink *sw_blink = uc_plat->sw_blink;
 	struct led_ops *ops = led_get_ops(dev);
 	int half_period_us;
+	int ret = 0;
 
 	half_period_us = period_ms * 1000 / 2;
 
@@ -71,8 +72,8 @@ int led_sw_set_period(struct udevice *dev, int period_ms)
 	}
 
 	if (sw_blink->state == LED_SW_BLINK_ST_DISABLED) {
-		cyclic_register(&sw_blink->cyclic, led_sw_blink,
-				half_period_us, sw_blink->cyclic_name);
+		ret = cyclic_register(&sw_blink->cyclic, led_sw_blink,
+				      half_period_us, sw_blink->cyclic_name);
 	} else {
 		sw_blink->cyclic.delay_us = half_period_us;
 		sw_blink->cyclic.start_time_us = timer_get_us();
@@ -81,7 +82,7 @@ int led_sw_set_period(struct udevice *dev, int period_ms)
 	sw_blink->state = LED_SW_BLINK_ST_NOT_READY;
 	ops->set_state(dev, LEDST_OFF);
 
-	return 0;
+	return ret;
 }
 
 bool led_sw_is_blinking(struct udevice *dev)
-- 
2.45.2



More information about the U-Boot mailing list