[PATCH 7/8] arm64: renesas: Deduplicate board_early_init_f()

Marek Vasut marek.vasut at mailbox.org
Sat Jan 18 08:59:24 CET 2025


On 1/13/25 4:40 PM, Adam Ford wrote:
> On Sun, Jan 12, 2025 at 4:36 PM Marek Vasut
> <marek.vasut+renesas at mailbox.org> wrote:
>>
>> Introduce common weak board_early_init_f() in rcar64-common.c
>> which is the default implementation in case there is no other
>> board specific board_early_init_f(). Remove board_early_init_f()
>> from Salvator-X, ULCB and Draak boards where this function is
>> empty.
> 
> Isn't there a config option to enable/disable board_early_init_f?  If
> they are do-nothing functions, can the config option be disabled?
There is , but I am still on the fence whether it wouldn't be better to 
remove it in favor of weak symbol, which would get optimized out. I 
think it is more user friendly as user does not have to fiddle with any 
config options, only fill in the non-weak symbol with content in their 
board file and it automatically takes effect.


More information about the U-Boot mailing list