[PATCH] doc: coolpi: Fix the defconfig name

Andy Yan andyshrk at 163.com
Sun Jan 19 10:25:07 CET 2025


Hi Quentin,

At 2025-01-15 17:29:10, "Quentin Schulz" <quentin.schulz at cherry.de> wrote:
>Hi Andy,
>
>On 1/13/25 11:56 AM, Andy Yan wrote:
>> The defconfig name should be: coolpi-cm5-genbook-rk3588_defconfig
>> 
>> Signed-off-by: Andy Yan <andyshrk at 163.com>
>
>Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

First,  thanks for your review.

>
>> ---
>> 
>>   doc/board/coolpi/genbook_cm5_rk3588.rst | 2 +-
>
>What about renaming every file that are inconsistent in naming?
>
>board/coolpi/genbook_cm5_rk3588/ to board/coolpi/cm5_genbook_rk3588/
>doc/board/coolpi/genbook_cm5_rk3588.rst to 
>doc/board/coolpi/cm5_genbook_rk3588.rst
>include/configs/genbook-cm5-rk3588.h to include/configs/cm5-genbook-rk3588.h
>
>If we do this change, we also need to change a few variables in 
>Kconfig/defconfig. If we do this change, it needs to be done in a 
>separate patch though!

Please check the review records when I first submitted the patch for this board's support[0][1],

As for myself, I can accept both naming conventions. However, different reviewer  seem to have different
nameing rules. 

[0]https://lore.kernel.org/u-boot/20240811100255.1664095-1-andyshrk@163.com/
[1]https://lore.kernel.org/u-boot/e251ab8c-f3d2-489e-a3c8-c7154e96c2e4@kwiboo.se/
>
>What do you think?

Anyway, I think this patch should be merged first to avoid misleading others who want to practice on their own.

>
>Cheers,
>Quentin


More information about the U-Boot mailing list