[PATCH v2 3/9] usb: dwc3-generic: Reorder include

[Patrice CHOTARD]

On 1/16/25 11:12, Mattijs Korpershoek wrote:
> Hi Patrice,
> 
> Thank you for the patch.
> 
> On jeu., janv. 16, 2025 at 09:17, Patrice Chotard <patrice.chotard at foss.st.com> wrote:
> 
>> Reorder include following rules available here :
>> https://docs.u-boot.org/en/latest/develop/codingstyle.html#include-files
> 
> Nitpick: we don't state in the commit message that we also removed the
> unused includes.
> A sentence like: "While at it, also remove the unused includes" would be
> nice to have.
> 
> If you need to send v3 for other reasons than this comment, please
> consider adding it.

Yes, i will update the comment
Thanks

Patrice

> 
> In case, this is a nitpick, so:
> 
> Reviewed-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
> 
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard at foss.st.com>
>> Cc: Marek Vasut <marex at denx.de>
>>
>> ---
>>
>> Changes in v2:
>>   - remove useless include files
>>
>>  drivers/usb/dwc3/dwc3-generic.c | 20 ++++----------------
>>  1 file changed, 4 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
>> index 2ab41cbae45..bc7d2d4234b 100644
>> --- a/drivers/usb/dwc3/dwc3-generic.c
>> +++ b/drivers/usb/dwc3/dwc3-generic.c
>> @@ -7,29 +7,17 @@
>>   * Based on dwc3-omap.c.
>>   */
>>  
>> -#include <cpu_func.h>
>> -#include <log.h>
>>  #include <dm.h>
>> -#include <dm/device-internal.h>
>> +#include <reset.h>
>> +#include <asm/gpio.h>
>>  #include <dm/lists.h>
>> -#include <dwc3-uboot.h>
>> -#include <generic-phy.h>
>> -#include <linux/bitops.h>
>>  #include <linux/delay.h>
>> -#include <linux/printk.h>
>> -#include <linux/usb/ch9.h>
>>  #include <linux/usb/gadget.h>
>> -#include <malloc.h>
>>  #include <power/regulator.h>
>> -#include <usb.h>
>> -#include "core.h"
>> -#include "gadget.h"
>> -#include <reset.h>
>> -#include <clk.h>
>>  #include <usb/xhci.h>
>> -#include <asm/gpio.h>
>> -
>> +#include "core.h"
>>  #include "dwc3-generic.h"
>> +#include "gadget.h"
>>  
>>  struct dwc3_generic_plat {
>>  	fdt_addr_t base;
>> -- 
>> 2.25.1