[U-Boot][PATCH v3 4/4] fpga: xilinx exclusive commands

[Erkiaga Elorza, Ibai]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Alexander,

Thanks for the review, not sure how I missed this one 🙁. The FPGA_XILINX is dependency not a select in this case, I think I accidentally wrote in the wrong line when doing some rewrite of my patch. Will fix in the next version once Michal finishes his review.

Regards
Ibai

________________________________
From: Alexander Dahl <ada at thorsis.com>
Sent: 20 January 2025 08:57
To: Erkiaga Elorza, Ibai <ibai.erkiaga-elorza at amd.com>
Cc: u-boot at lists.denx.de <u-boot at lists.denx.de>; Simek, Michal <michal.simek at amd.com>
Subject: Re: [U-Boot][PATCH v3 4/4] fpga: xilinx exclusive commands

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Hello,

Am Fri, Jan 17, 2025 at 11:25:51AM +0000 schrieb Ibai Erkiaga:
> @@ -1192,7 +1198,7 @@ config CMD_FPGA_LOADMK
>  config CMD_FPGA_LOAD_SECURE
>       bool "fpga loads - loads secure bitstreams"
>       depends on CMD_FPGA
> -     select FPGA_LOAD_SECURE
> +     select FPGA_LOAD_SECURE && FPGA_XILINX
>       help
>         Enables the fpga loads command which is used to load secure
>         (authenticated or encrypted or both) bitstreams on to FPGA.

This does not work, you need to have one line per selected kconfig
symbol.  Your change leads to this:

    cmd/Kconfig:1184: syntax error
    cmd/Kconfig:1183: invalid option

You should have noticed this when testing. ;-)

Greets
Alex