[PATCH v1] arm: Remove redundant loading of image copy start offse

[Simon Glass]

Hi Liya,

On Sat, 18 Jan 2025 at 09:40, Tom Rini <trini at konsulko.com> wrote:
>
> On Sat, Jan 18, 2025 at 11:39:18AM +0800, 1425075683 at qq.com wrote:
>
> > From: Liya Huang <1425075683 at qq.com>
> >
> > Remove redundant loading of image copy start offset.
> > Because the beginning is already computed
> >
> > Reviewed-by: Pali Rohár <pali at kernel.org>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> > Signed-off-by: Liya Huang <1425075683 at qq.com>
> > ---
> >
> > Changes in v1:
> > - Due to an error, the patch was resubmitted, leaving the code unchanged
> >
> >  arch/arm/lib/relocate.S | 2 --
> >  1 file changed, 2 deletions(-)
>
> I don't understand what you're doing. Please stop posting patches that
> have "Reviewed-by" tags on them without pointing to other evidence that
> the person in question supplied that tag somewhere else in public.
> Thanks.

Just to explain that a bit more, when you send a patch it normally
should just have your 'Signed-off-by:' line. Then, other people reply
to your patch with 'Reviewed-by name <email>' tags and these get
collected by patchwork.

If you then send a new version (say v2), you can collect the tags from
v1 and add them to you patch. But until then you should not add your
own 'Reviewed-by' tags since it suggests that others have already
reviewed the patch, when they haven't :-)

Regards,
Simon