[PATCH] net: miiphybb: Fix short name length

Paul Barker paul.barker.ct at bp.renesas.com
Tue Jan 21 12:56:27 CET 2025


On 18/01/2025 06:15, Marek Vasut wrote:
> Multiple drivers copy MDIO name into struct bb_miiphy_bus name, but
> these two name fields have different length, the bb_miiphy_bus one
> is 16 bytes, the source one is 32 bytes. Make sure these two lengths
> are always synchronized, use MDIO_NAME_LEN for both.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>

I would prefer something like the following so that it's clear which
source struct we're referring to:

    Multiple drivers copy the MDIO instance name from struct mii_phy to
    struct bb_miiphy_bus, but the name field in these two structs have
    different lengths...

With that changed,

Reviewed-by: Paul Barker <paul.barker.ct at bp.renesas.com>

-- 
Paul Barker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x27F4B3459F002257.asc
Type: application/pgp-keys
Size: 3520 bytes
Desc: OpenPGP public key
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250121/2a847319/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250121/2a847319/attachment.sig>


More information about the U-Boot mailing list