[PATCH 4/7] spi: atmel-quadspi: Remove default mode setting at probe time

Alexander Dahl ada at thorsis.com
Thu Jan 23 13:12:12 CET 2025


The Serial Memory Mode (SMM) is enabled with atmel_qspi_set_cfg() on
each invocation of atmel_qspi_exec_op().  Setting SMM through
atmel_qspi_init() at probe time is redundant.

Removing the SMM setting at probe time should therefore 1) be safe to do
and 2) allows for setting it to a different value in a future
implementation of .xfer() which needs to disable SMM.

Signed-off-by: Alexander Dahl <ada at thorsis.com>
---
 drivers/spi/atmel-quadspi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index 9e596b7448c..467f29c01ca 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -1052,11 +1052,6 @@ static int atmel_qspi_init(struct atmel_qspi *aq)
 	/* Reset the QSPI controller */
 	atmel_qspi_write(QSPI_CR_SWRST, aq, QSPI_CR);
 
-	/* Set the QSPI controller by default in Serial Memory Mode */
-	ret = atmel_qspi_set_serial_memory_mode(aq);
-	if (ret < 0)
-		return ret;
-
 	/* Enable the QSPI controller */
 	atmel_qspi_write(QSPI_CR_QSPIEN, aq, QSPI_CR);
 
-- 
2.39.5



More information about the U-Boot mailing list