[PATCH] fs: ubifs: Remove unnecessary assignment

[Alexander Dahl]

Hello Michal,

Am Fri, Jan 24, 2025 at 02:17:57PM +0100 schrieb Michal Simek:
> Variable self assignment has been found by clang. But Linux kernel already
> fixed this problem by commit 2a068daf5742 ("ubifs: Remove unnecessary
> assignment") and commit ae4c8081eb77 ("ubifs: remove unnecessary
> assignment").
> 
> Signed-off-by: Michal Simek <michal.simek at amd.com>
> ---
> 
>  fs/ubifs/recovery.c | 1 -
>  fs/ubifs/scan.c     | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
> index 6b6884fb2098..12c0575cc976 100644
> --- a/fs/ubifs/recovery.c
> +++ b/fs/ubifs/recovery.c
> @@ -439,7 +439,6 @@ static void clean_buf(const struct ubifs_info *c, void **buf, int lnum,
>  {
>  	int empty_offs, pad_len;
>  
> -	lnum = lnum;
>  	dbg_rcvry("cleaning corruption at %d:%d", lnum, *offs);
>  
>  	ubifs_assert(!(*offs & 7));
> diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
> index 7a6e46df5d90..2335e9e2d256 100644
> --- a/fs/ubifs/scan.c
> +++ b/fs/ubifs/scan.c
> @@ -169,7 +169,6 @@ struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
>  void ubifs_end_scan(const struct ubifs_info *c, struct ubifs_scan_leb *sleb,
>  		    int lnum, int offs)
>  {
> -	lnum = lnum;
>  	dbg_scan("stop scanning LEB %d at offset %d", lnum, offs);
>  	ubifs_assert(offs % c->min_io_size == 0);

Wow, these are old, both date back to 2009 in U-Boot.

Reviewed-by: Alexander Dahl <ada at thorsis.com>

Greets
Alex