[PATCH v4 03/20] pinctrl: nxp: add a pin controller driver based on SCMI pin control protocol

[Marek Vasut]

On 1/15/25 2:28 PM, Alice Guo wrote:
> From: Alice Guo <alice.guo at nxp.com>
> 
> This patch provides a pinctrl driver based on SCMI pin control protocol.
> Currently, only the PINCTRL_CONFIG_SET command is implemented.
> 
> Signed-off-by: Ranjani Vaidyanathan <Ranjani.Vaidyanathan at nxp.com>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> Signed-off-by: Alice Guo <alice.guo at nxp.com>
> Reviewed-by: Ye Li <ye.li at nxp.com>
> ---
>   drivers/pinctrl/nxp/Kconfig        |  13 ++++
>   drivers/pinctrl/nxp/Makefile       |   1 +
>   drivers/pinctrl/nxp/pinctrl-imx.c  |   7 +-
>   drivers/pinctrl/nxp/pinctrl-imx.h  |  11 +++
>   drivers/pinctrl/nxp/pinctrl-scmi.c | 136 +++++++++++++++++++++++++++++++++++++
>   include/scmi_protocols.h           |  34 ++++++++++
>   6 files changed, 200 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/nxp/Kconfig b/drivers/pinctrl/nxp/Kconfig
> index 06c26f156f6c8f63204604d6065485629cfd9b61..ec63ab595650d0dfab7e3a7dc01d4af7814b6773 100644
> --- a/drivers/pinctrl/nxp/Kconfig
> +++ b/drivers/pinctrl/nxp/Kconfig
> @@ -1,6 +1,19 @@
>   config PINCTRL_IMX
>   	bool
>   
> +config PINCTRL_IMX_SCMI
> +	bool "IMX pinctrl SCMI driver"

i.MX instead of IMX ? Please be sure to use the branding consistently 
across Kconfig entries and various text fields.

> +	depends on ARCH_IMX9 && PINCTRL_FULL

Is this really supposed to be available for all iMX9* or is this limited 
to iMX95 ?

> +	select PINCTRL_IMX
> +	help
> +	  Say Y here to enable the imx pinctrl SCMI driver

This Say Y stuff goes ...

> +	  This provides a simple pinctrl driver for i.MX SoC which supports
> +	  SCMI. This feature depends on device tree configuration. This driver
> +	  is different from the linux one, this is a simple implementation,
> +	  only parses the 'fsl,pins' property and configure related
> +	  registers.

... here, at the end.

>   config PINCTRL_IMX_SCU
>   	bool
I have posted a couple of pinctrl patches to [1] , that should simplify 
this pinctrl implementation. The entire series is also available in [2] 
, the updated mx95 pinctrl patch on top of it is [3] .

[1] https://lore.kernel.org/u-boot/20250124145520.185414-1-marex@denx.de/
[2] 
https://source.denx.de/u-boot/custodians/u-boot-usb/-/commits/test-pinctrl
[3] 
https://source.denx.de/u-boot/custodians/u-boot-usb/-/commit/3191ef0497c629017da4d88bf6a14ff0ad7c0032