[PATCH 4/4] test: Make net tests depend on CONFIG_CMD_NET

Simon Glass sjg at chromium.org
Sat Jan 25 23:47:26 CET 2025


Hi Tom,

On Sat, 25 Jan 2025 at 14:44, Tom Rini <trini at konsulko.com> wrote:
>
> On Sat, Jan 25, 2025 at 02:31:39PM -0700, Simon Glass wrote:
> > This fails on samus_tpl as there is no 'net' command.
> >
> >    => net list
> >    Unknown command 'net' - try 'help' !
> >
> > Fix it by adding a condition for the test.
>
> For this part,
> Reviewed-by: Tom Rini <trini at konsulko.com>
>
> > Add a blank line to keep pylint happy.
>
> Can we silence that pylint? I don't look forward to the churn of adding
> more blanks everywhere especially since imo it doesn't improve
> readability either.

Yes, but we would want to do it globally. But it isn't really a good
idea IMO. We are trying to use PEP8 which loads of tools expect...e.g.
my IDE shows warnings in this case. It might be better to just fix the
problems.

As to readability, I'm on the fence...in practice it doesn't matter
much as few non-trivial programs have a lot of top-level functions. I
would rather keep the tool happy and use the Python style that people
expect when coming into the project.

Regards,
Simon


More information about the U-Boot mailing list