[PATCH] arm64: configs: Remove SYS_BOOTM_LEN for TI devices

Dhruva Gole d-gole at ti.com
Wed Jan 29 10:39:47 CET 2025


Hi Aashvij,

On Jan 29, 2025 at 13:06:08 +0530, Aashvij Shenai wrote:
> AM62x BOOTM_LEN is too small to contain OS images. Removing this sets the
> size to a default 0x4000000 (for all arm64 devices).
> 
> It is unnecessary to specifically call the default size for the other
> configs.
> 
> Signed-off-by: Kamlesh Gurudasani <kamlesh at ti.com>
> Signed-off-by: Aashvij Shenai <a-shenai at ti.com>
> ---

$subject doesn't tell if it's an upstream patch that you want review on
or if it's for ti-u-boot. So not getting the full context of what this
patch is aimed toward.

One other tip - use --base parameter while generating the patch file to
include the commit SHA on which your patch is based on.

Otherwise, LGTM

Reviewed-by: Dhruva Gole <d-gole at ti.com>

> 
> Reference patch: https://lore.kernel.org/u-boot/20240708-remove-bootm-len-v1-1-2a537061426c@ti.com/
> 
> ---
>  configs/am62x_beagleplay_a53_defconfig | 1 -
>  configs/am62x_evm_a53_defconfig        | 1 -
>  configs/am65x_evm_r5_defconfig         | 1 -
>  configs/am65x_evm_r5_usbdfu_defconfig  | 1 -
>  configs/am65x_evm_r5_usbmsc_defconfig  | 1 -
>  configs/j721e_evm_r5_defconfig         | 1 -
>  configs/j721s2_evm_r5_defconfig        | 1 -
>  7 files changed, 7 deletions(-)
> 
> diff --git a/configs/am62x_beagleplay_a53_defconfig b/configs/am62x_beagleplay_a53_defconfig
> index af54f9670a7..a8a73166597 100644
> --- a/configs/am62x_beagleplay_a53_defconfig
> +++ b/configs/am62x_beagleplay_a53_defconfig
> @@ -30,7 +30,6 @@ CONFIG_SPL_LIBDISK_SUPPORT=y
>  CONFIG_SPL_LOAD_FIT=y
>  CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
>  CONFIG_BOOTSTD_FULL=y
> -CONFIG_SYS_BOOTM_LEN=0x800000
>  CONFIG_AUTOBOOT_KEYED=y
>  CONFIG_AUTOBOOT_PROMPT="Press SPACE to abort autoboot in %d seconds\n"
>  CONFIG_AUTOBOOT_DELAY_STR="d"
> diff --git a/configs/am62x_evm_a53_defconfig b/configs/am62x_evm_a53_defconfig
> index 000f412d4b8..a915ef428b0 100644
> --- a/configs/am62x_evm_a53_defconfig
> +++ b/configs/am62x_evm_a53_defconfig
> @@ -33,7 +33,6 @@ CONFIG_SPL_SPI=y
>  CONFIG_SPL_LOAD_FIT=y
>  CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
>  CONFIG_BOOTSTD_FULL=y
> -CONFIG_SYS_BOOTM_LEN=0x800000
>  CONFIG_BOOTCOMMAND="run findfdt; run envboot; bootflow scan -lb"
>  CONFIG_BOARD_LATE_INIT=y
>  CONFIG_SPL_MAX_SIZE=0x58000
> diff --git a/configs/am65x_evm_r5_defconfig b/configs/am65x_evm_r5_defconfig
> index 4bd5e8f63ff..289c41c3eb5 100644
> --- a/configs/am65x_evm_r5_defconfig
> +++ b/configs/am65x_evm_r5_defconfig
> @@ -24,7 +24,6 @@ CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
>  CONFIG_SPL_BSS_START_ADDR=0x41c7effc
>  CONFIG_SPL_BSS_MAX_SIZE=0xc00
>  CONFIG_SPL_STACK_R=y
> -CONFIG_SYS_BOOTM_LEN=0x4000000
>  CONFIG_SPL_SIZE_LIMIT=0x7ec00
>  CONFIG_SPL_SIZE_LIMIT_PROVIDE_STACK=0x2000
>  CONFIG_SPL_FS_FAT=y
> diff --git a/configs/am65x_evm_r5_usbdfu_defconfig b/configs/am65x_evm_r5_usbdfu_defconfig
> index ae57007d898..0b5eaeb363d 100644
> --- a/configs/am65x_evm_r5_usbdfu_defconfig
> +++ b/configs/am65x_evm_r5_usbdfu_defconfig
> @@ -22,7 +22,6 @@ CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
>  CONFIG_SPL_BSS_START_ADDR=0x41c7effc
>  CONFIG_SPL_BSS_MAX_SIZE=0xc00
>  CONFIG_SPL_STACK_R=y
> -CONFIG_SYS_BOOTM_LEN=0x4000000
>  CONFIG_SPL_SIZE_LIMIT=0x7ec00
>  CONFIG_SPL_SIZE_LIMIT_PROVIDE_STACK=0x2000
>  CONFIG_SPL_LIBDISK_SUPPORT=y
> diff --git a/configs/am65x_evm_r5_usbmsc_defconfig b/configs/am65x_evm_r5_usbmsc_defconfig
> index 3aa17eb77f0..ef2ff411172 100644
> --- a/configs/am65x_evm_r5_usbmsc_defconfig
> +++ b/configs/am65x_evm_r5_usbmsc_defconfig
> @@ -22,7 +22,6 @@ CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
>  CONFIG_SPL_BSS_START_ADDR=0x41c7effc
>  CONFIG_SPL_BSS_MAX_SIZE=0xc00
>  CONFIG_SPL_STACK_R=y
> -CONFIG_SYS_BOOTM_LEN=0x4000000
>  CONFIG_SPL_SIZE_LIMIT=0x7ec00
>  CONFIG_SPL_SIZE_LIMIT_PROVIDE_STACK=0x2000
>  CONFIG_SPL_FS_FAT=y
> diff --git a/configs/j721e_evm_r5_defconfig b/configs/j721e_evm_r5_defconfig
> index 9d767d7cdad..702fe90b902 100644
> --- a/configs/j721e_evm_r5_defconfig
> +++ b/configs/j721e_evm_r5_defconfig
> @@ -26,7 +26,6 @@ CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
>  CONFIG_SPL_BSS_START_ADDR=0x41cf59f0
>  CONFIG_SPL_BSS_MAX_SIZE=0xa000
>  CONFIG_SPL_STACK_R=y
> -CONFIG_SYS_BOOTM_LEN=0x4000000
>  CONFIG_SPL_SIZE_LIMIT=0xf59f0
>  CONFIG_SPL_SIZE_LIMIT_PROVIDE_STACK=0x4000
>  CONFIG_SPL_FS_FAT=y
> diff --git a/configs/j721s2_evm_r5_defconfig b/configs/j721s2_evm_r5_defconfig
> index 23ae991e2f6..7ec9af8bc48 100644
> --- a/configs/j721s2_evm_r5_defconfig
> +++ b/configs/j721s2_evm_r5_defconfig
> @@ -26,7 +26,6 @@ CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
>  CONFIG_SPL_BSS_START_ADDR=0x41c76000
>  CONFIG_SPL_BSS_MAX_SIZE=0xa000
>  CONFIG_SPL_STACK_R=y
> -CONFIG_SYS_BOOTM_LEN=0x4000000
>  CONFIG_SPL_SIZE_LIMIT=0x80000
>  CONFIG_SPL_SIZE_LIMIT_PROVIDE_STACK=0x4000
>  CONFIG_SPL_FS_FAT=y
> -- 
> 2.34.1
> 

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated


More information about the U-Boot mailing list