[PATCH 15/20] ram: rockchip: Add rk3576 ddr driver support

[Jonas Karlman]

Hi Heiko,

On 2024-11-21 15:27, Heiko Stuebner wrote:
> Add ddr driver for rk3576 to get the ram capacity.
> 
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> ---
>  drivers/ram/rockchip/Makefile       |  1 +
>  drivers/ram/rockchip/sdram_rk3576.c | 65 +++++++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
>  create mode 100644 drivers/ram/rockchip/sdram_rk3576.c
> 
> diff --git a/drivers/ram/rockchip/Makefile b/drivers/ram/rockchip/Makefile
> index 36dc0500dab..442fe73deb6 100644
> --- a/drivers/ram/rockchip/Makefile
> +++ b/drivers/ram/rockchip/Makefile
> @@ -14,6 +14,7 @@ obj-$(CONFIG_ROCKCHIP_RK3308) = sdram_rk3308.o
>  obj-$(CONFIG_ROCKCHIP_RK3328) = sdram_rk3328.o sdram_pctl_px30.o sdram_phy_px30.o
>  obj-$(CONFIG_ROCKCHIP_RK3399) += sdram_rk3399.o
>  obj-$(CONFIG_ROCKCHIP_RK3568) += sdram_rk3568.o
> +obj-$(CONFIG_ROCKCHIP_RK3576) += sdram_rk3576.o
>  obj-$(CONFIG_ROCKCHIP_RK3588) += sdram_rk3588.o
>  obj-$(CONFIG_ROCKCHIP_RV1126) += sdram_rv1126.o sdram_pctl_px30.o
>  obj-$(CONFIG_ROCKCHIP_SDRAM_COMMON) += sdram_common.o
> diff --git a/drivers/ram/rockchip/sdram_rk3576.c b/drivers/ram/rockchip/sdram_rk3576.c
> new file mode 100644
> index 00000000000..fa4187a5860
> --- /dev/null
> +++ b/drivers/ram/rockchip/sdram_rk3576.c
> @@ -0,0 +1,65 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * (C) Copyright 2024 Rockchip Electronics Co., Ltd.
> + */
> +
> +#include <config.h>
> +#include <dm.h>
> +#include <ram.h>
> +#include <syscon.h>
> +#include <asm/arch-rockchip/clock.h>
> +#include <asm/arch-rockchip/grf_rk3576.h>
> +#include <asm/arch-rockchip/sdram.h>
> +
> +struct dram_info {
> +	struct ram_info info;
> +	struct rk3576_pmu1grf *pmugrf;
> +};
> +
> +static int rk3576_dmc_probe(struct udevice *dev)
> +{
> +	struct dram_info *priv = dev_get_priv(dev);
> +
> +	priv->pmugrf = syscon_get_first_range(ROCKCHIP_SYSCON_PMUGRF);
> +
> +	/*
> +	 * On a 16GB board the DDR ATAG reports:
> +	 * start 0x40000000, size 0x400000000
> +	 * While the size value from the pmugrf below reports
> +	 * pmugrf->osreg2: 0x400000000
> +	 * pmugrf->osreg4:  0x10000000
> +	 * So it seems only osreg2 is responsible for the ram size.
> +	 */
> +	priv->info.base = CFG_SYS_SDRAM_BASE;
> +	priv->info.size =
> +		rockchip_sdram_size((phys_addr_t)&priv->pmugrf->os_reg[2]);
> +
> +	return 0;
> +}
> +
> +static int rk3576_dmc_get_info(struct udevice *dev, struct ram_info *info)
> +{
> +	struct dram_info *priv = dev_get_priv(dev);
> +
> +	*info = priv->info;
> +
> +	return 0;
> +}

Both the probe and above get_info can be simplified into something like:

#define PMU1GRF_BASE			0x26026000
#define OS_REG2_REG			0x208

static int rk3576_dmc_get_info(struct udevice *dev, struct ram_info *info)
{
	info->base = CFG_SYS_SDRAM_BASE;
	info->size = rockchip_sdram_size(PMU1GRF_BASE + OS_REG2_REG);

	return 0;
}

With above the grf_rk3576.h could also be dropped/removed.

> +
> +static struct ram_ops rk3576_dmc_ops = {
> +	.get_info = rk3576_dmc_get_info,
> +};
> +
> +static const struct udevice_id rk3576_dmc_ids[] = {
> +	{ .compatible = "rockchip,rk3576-dmc" },
> +	{ }
> +};
> +
> +U_BOOT_DRIVER(dmc_rk3576) = {
> +	.name = "rockchip_rk3576_dmc",
> +	.id = UCLASS_RAM,
> +	.of_match = rk3576_dmc_ids,
> +	.ops = &rk3576_dmc_ops,
> +	.probe = rk3576_dmc_probe,
> +	.priv_auto = sizeof(struct dram_info),

With the probe function removed we can also remove the priv data.

> +};

Regards,
Jonas