[PATCH] clk: Return value calculated by ERR_PTR

Quentin Schulz quentin.schulz at cherry.de
Mon Jul 14 14:37:33 CEST 2025


Hi Andrew,

On 7/3/25 4:40 PM, Andrew Goodbody wrote:
> In clk_set_default_get_by_id ret is passed to ERR_PTR but nothing is
> done with the value that this calculates which is obviously not the
> intention of the code. This is confirmed by the code around where this
> function is called.

Indeed, they do check the return code with IS_ERR() which indicates 
there should be something returning an error pointer somewhere, which 
doesn't happen right now?

So this seems like a valid change to do.

Acked-by: Quentin Schulz <quentin.schulz at cherry.de>

Thanks!
Quentin


More information about the U-Boot mailing list